Re: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-04-08 Thread Phil Race
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy wrote: > The fix provides ability to print Black & White pages on macOS. > > Cocoa API has > [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) > function but it is marked

Re: RFR: JDK-8298405: Implement JEP 467: Markdown Documentation Comments [v55]

2024-04-08 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Erik Joelsson
On Mon, 8 Apr 2024 09:20:44 GMT, Daniel Jeliński wrote: > The RejectedExecutionException was thrown when the thread executing > `Server.start` managed to shut down the `compilerThreadPool` before the > thread executing `Server.handleRequest` submitted the compilation task. > > This patch remov

Re: RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Erik Joelsson
On Mon, 8 Apr 2024 14:27:28 GMT, Daniel Jeliński wrote: > It won't be a problem. The client side does not set timeout on socket > read/write operations, so there's no risk of the operation timing out. Also, > the OS usually buffers reads and writes, so the client write call probably > won't bl

Re: RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Daniel Jeliński
On Mon, 8 Apr 2024 09:20:44 GMT, Daniel Jeliński wrote: > The RejectedExecutionException was thrown when the thread executing > `Server.start` managed to shut down the `compilerThreadPool` before the > thread executing `Server.handleRequest` submitted the compilation task. > > This patch remov

Re: RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Erik Joelsson
On Mon, 8 Apr 2024 09:20:44 GMT, Daniel Jeliński wrote: > The RejectedExecutionException was thrown when the thread executing > `Server.start` managed to shut down the `compilerThreadPool` before the > thread executing `Server.handleRequest` submitted the compilation task. > > This patch remov

Re: RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Christian Stein
On Mon, 8 Apr 2024 09:20:44 GMT, Daniel Jeliński wrote: > The RejectedExecutionException was thrown when the thread executing > `Server.start` managed to shut down the `compilerThreadPool` before the > thread executing `Server.handleRequest` submitted the compilation task. > > This patch remov

RFR: 8324673: javacserver failed during build: RejectedExecutionException

2024-04-08 Thread Daniel Jeliński
The RejectedExecutionException was thrown when the thread executing `Server.start` managed to shut down the `compilerThreadPool` before the thread executing `Server.handleRequest` submitted the compilation task. This patch removes the extra thread used for `Server.handleRequest`, and executes t