Re: RFR: 8330107: Split Awt2dLibraries.gmk into separate AWT and 2D files

2024-04-12 Thread Phil Race
On Thu, 11 Apr 2024 13:59:30 GMT, Magnus Ihse Bursie wrote: > @prrace I will need your assistance in confirming that my understanding about > the AWT vs 2D split is correct. In particular, `libosxui` gave me some > headache, but after trying to dig into the code my understanding ended up > bei

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v3]

2024-04-12 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when i

Integrated: 8330110: AIX build fails after JDK-8329704 - issue with libjli.a

2024-04-12 Thread Magnus Ihse Bursie
On Fri, 12 Apr 2024 12:26:06 GMT, Magnus Ihse Bursie wrote: > Unfortunately, after > [JDK-8329704](https://bugs.openjdk.org/browse/JDK-8329704) AIX fails to > build. The reason is that libjli is specially treated on AIX, and built like > a static library. I tried to compensate for this (and ha

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]

2024-04-12 Thread Joe Darcy
On Thu, 11 Apr 2024 17:52:14 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v2]

2024-04-12 Thread Jonathan Gibbons
On Wed, 3 Apr 2024 10:01:37 GMT, Magnus Ihse Bursie wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adjust call for `saveDanglingDocComments` for enum members > > The build changes look okay. > > Do you have

Re: RFR: 8330110: AIX build fails after JDK-8329704 - issue with libjli.a

2024-04-12 Thread Martin Doerr
On Fri, 12 Apr 2024 12:26:06 GMT, Magnus Ihse Bursie wrote: > Unfortunately, after > [JDK-8329704](https://bugs.openjdk.org/browse/JDK-8329704) AIX fails to > build. The reason is that libjli is specially treated on AIX, and built like > a static library. I tried to compensate for this (and ha

Re: RFR: 8330110: AIX build fails after JDK-8329704 - issue with libjli.a

2024-04-12 Thread Matthias Baesken
On Fri, 12 Apr 2024 12:26:06 GMT, Magnus Ihse Bursie wrote: > Unfortunately, after > [JDK-8329704](https://bugs.openjdk.org/browse/JDK-8329704) AIX fails to > build. The reason is that libjli is specially treated on AIX, and built like > a static library. I tried to compensate for this (and ha

RFR: 8330110: AIX build fails after JDK-8329704 - issue with libjli.a

2024-04-12 Thread Magnus Ihse Bursie
Unfortunately, after [JDK-8329704](https://bugs.openjdk.org/browse/JDK-8329704) AIX fails to build. The reason is that libjli is specially treated on AIX, and built like a static library. I tried to compensate for this (and had tested on an earlier draft), but some late-minute changes in JDK-832

Re: Questions about the Hermetic Java project

2024-04-12 Thread Magnus Ihse Bursie
On 2024-04-02 21:16, Jiangli Zhou wrote: Hi Magnus, In today's zoom meeting with Alan, Ron, Liam and Chuck, we (briefly) discussed how to move forward contributing the static Java related changes (additional runtime fixes/enhancements on top of the existing static support in JDK) from https