Re: RFR: 8330182: Start of release updates for JDK 24 [v3]

2024-04-29 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Update

Re: RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect

2024-04-29 Thread Erik Joelsson
On Mon, 29 Apr 2024 16:14:45 GMT, SendaoYan wrote: > Hi, > > In doc/testing.md file, it says: > > As an example, :tier1 will expand to jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 > jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1 > jtreg:$(TOPDIR)/test/nashorn:tier1

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v59]

2024-04-29 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` >

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-29 Thread SendaoYan
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >>

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-29 Thread Aleksey Shipilev
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >>

Integrated: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-29 Thread SendaoYan
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >>

Re: RFR: 8330182: Start of release updates for JDK 24 [v2]

2024-04-29 Thread Joe Darcy
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote: > There are further updates to this test in the pipeline (new deprecated flags > in 23) so you will need to keep updating to reflect that. Thanks @dholmes-ora ; acknowledged. - PR Review Comment:

Re: RFR: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]

2024-04-29 Thread Joachim Kern
On Thu, 18 Apr 2024 04:26:21 GMT, Kim Barrett wrote: >> I opened https://bugs.openjdk.org/browse/JDK-8330539 so we don't lose track >> of this, but we can keep the discussion/voting here. > > For the impatient, I suggest adopting mechanism 2, i.e. unconditionally > include in

RFR: 8331331: :tier1 target explanation in doc/testing.md is incorrect

2024-04-29 Thread SendaoYan
Hi, In doc/testing.md file, it says: As an example, :tier1 will expand to jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1 jtreg:$(TOPDIR)/test/nashorn:tier1 jtreg:$(TOPDIR)/test/jaxp:tier1. The actual situation is :tier1 doesn't

Re: RFR: 8331298: avoid alignment checks in UBSAN enabled build

2024-04-29 Thread Martin Doerr
On Mon, 29 Apr 2024 12:15:55 GMT, Matthias Baesken wrote: > Currently we run into some alignment related issues when building with > '--enable-ubsan' . Those errors already occur in the build. Fixing them might > take some time and maybe also some discussion if it is worth the effort , > So

Re: RFR: 8331298: avoid alignment checks in UBSAN enabled build

2024-04-29 Thread Erik Joelsson
On Mon, 29 Apr 2024 12:15:55 GMT, Matthias Baesken wrote: > Currently we run into some alignment related issues when building with > '--enable-ubsan' . Those errors already occur in the build. Fixing them might > take some time and maybe also some discussion if it is worth the effort , > So

RFR: 8331298: avoid alignment checks in UBSAN enabled build

2024-04-29 Thread Matthias Baesken
Currently we run into some alignment related issues when building with '--enable-ubsan' . Those errors already occur in the build. Fixing them might take some time and maybe also some discussion if it is worth the effort , So for now the alignment related checks should be disabled to get the