Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v6]

2024-06-12 Thread Ioi Lam
> ### Overview > > This PR archives `CONSTANT_FieldRef` entries in the _resolved_ state when > it's safe to do so. > > I.e., when a `CONSTANT_FieldRef` constant pool entry in class `A` refers to a > *non-static* field `B.F`, > - `B` is the same class as `A`; or > - `B` is a supertype of `A`;

Re: RFR: 8334166: Enable binary check

2024-06-12 Thread Phil Race
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other similar resources, but

Re: RFR: 8334166: Enable binary check

2024-06-12 Thread Zhao Song
On Wed, 12 Jun 2024 22:49:30 GMT, Kevin Rushforth wrote: > How is this check presented to the PR author and Reviewers of a PR? Is it > listed as a warning similar to the issue title warning? Do you have a sample > PR (Draft is fine) that would show how this looks?

RFR: 8334166: Enable binary check

2024-06-12 Thread Zhao Song
@kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'.

Re: RFR: 8334166: Enable binary check

2024-06-12 Thread Kevin Rushforth
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other similar resources, but

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v32]

2024-06-12 Thread Severin Gehwolf
On Thu, 6 Jun 2024 15:35:20 GMT, Severin Gehwolf wrote: > My aim will be to bring this into JDK 24 with a JEP then. Hopefully we can > bring this to a successful conclusion that way. @AlanBateman JEP draft is here: https://openjdk.org/jeps/8333799 Could you please help review it? Thanks!

Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-12 Thread Sonia Zaldana Calles
On Wed, 12 Jun 2024 06:46:39 GMT, Thomas Stuefe wrote: > A lot better, but not fully there yet. Can you make it so that it also picks > up SAP's copyrights when they specify multiple years? They are weird in that > the last year does not have a trailing comma, e.g.: > > ``` > * Copyright (c)

Re: RFR: 8333685: Make update-copyright-year script more useful [v3]

2024-06-12 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). > > I have added the following enhancements: > - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` > respectively. > - Altered default behaviour to limit the processed changesets to those

Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-12 Thread Sonia Zaldana Calles
On Wed, 12 Jun 2024 06:43:15 GMT, Thomas Stuefe wrote: >> Sonia Zaldana Calles has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing optional group to work with bsd as well > > make/scripts/update_copyright_year.sh line 70: > >> 68:

Re: RFR: 8333685: Make update-copyright-year script more useful [v2]

2024-06-12 Thread Thomas Stuefe
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). >> >> I have added the following enhancements: >> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` >> respectively.

Integrated: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-12 Thread Matthias Baesken
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr >

Re: RFR: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

2024-06-12 Thread Matthias Baesken
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote: > When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure > flag --enable-ubsan), in a lot of jfr related tests like > compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr >