Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-14 Thread Volodymyr Paprotski
On Fri, 14 Jun 2024 20:23:04 GMT, Volodymyr Paprotski wrote: > This fix recovers XDH performance but removes some of the P256 gains > (~-8-14%). Still faster, but not as much. > > The fix is to undo 'int' return type on mult()/square(), which allowed to > return partially reduced result (i.e.

RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-14 Thread Volodymyr Paprotski
This fix recovers XDH performance but removes some of the P256 gains (~-8-14%). Still faster, but not as much. The fix is to undo 'int' return type on mult()/square(), which allowed to return partially reduced result (i.e. this avoids extra reductions when mult() result is fed into addition). T

Re: RFR: 8333268: Fixes for static build

2024-06-14 Thread Magnus Ihse Bursie
On Thu, 30 May 2024 13:00:21 GMT, Magnus Ihse Bursie wrote: > This patch contains a set of changes to improve static builds. They will pave > the way for implementing a full static-only java launcher. The changes here > will: > > 1) Make sure non-exported symbols are made local in the static l

Re: RFR: 8333268: Fixes for static build

2024-06-14 Thread Magnus Ihse Bursie
On Thu, 30 May 2024 13:00:21 GMT, Magnus Ihse Bursie wrote: > This patch contains a set of changes to improve static builds. They will pave > the way for implementing a full static-only java launcher. The changes here > will: > > 1) Make sure non-exported symbols are made local in the static l

RFR: 8333268: Fixes for static build

2024-06-14 Thread Magnus Ihse Bursie
This patch contains a set of changes to improve static builds. They will pave the way for implementing a full static-only java launcher. The changes here will: 1) Make sure non-exported symbols are made local in the static libraries. This means that the risk of symbol conflict is the same for s

Re: RFR: 8331552: Update to use jtreg 7.4

2024-06-14 Thread Erik Joelsson
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote: > Please review the change to update to using `jtreg` **7.4**. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredV

Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

2024-06-14 Thread Chen Liang
On Fri, 14 Jun 2024 10:52:40 GMT, Magnus Ihse Bursie wrote: >> Ah, I had not realized that there was more than 1 newline. GitHub's UI >> confused me here, so we're good to go > > GitHub's UI assumes the final line has an line break. If it is missing, it > displays a red 🚫 at the end of the last

Re: RFR: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32 [v2]

2024-06-14 Thread Aleksey Shipilev
> We have added these long time ago with > [JDK-8308086](https://bugs.openjdk.org/browse/JDK-8308086) and > [JDK-8293165](https://bugs.openjdk.org/browse/JDK-8293165) to stabilize > x86_32 sysroot a bit. We never backported those below JDK 21. Aleksey Shipilev has updated the pull request with

Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

2024-06-14 Thread Magnus Ihse Bursie
On Fri, 7 Jun 2024 13:34:45 GMT, Julian Waters wrote: >> I find the extra trailing newlines through below shell command: >> >> for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i | >> grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done >> >> >> Th

Re: RFR: 8331552: Update to use jtreg 7.4

2024-06-14 Thread Magnus Ihse Bursie
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote: > Please review the change to update to using `jtreg` **7.4**. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredV

Re: RFR: 8330586: GHA: Drop additional gcc/glibc packages installation for x86_32

2024-06-14 Thread Magnus Ihse Bursie
On Thu, 18 Apr 2024 14:28:37 GMT, Aleksey Shipilev wrote: > We have added these long time ago with > [JDK-8308086](https://bugs.openjdk.org/browse/JDK-8308086) and > [JDK-8293165](https://bugs.openjdk.org/browse/JDK-8293165) to stabilize > x86_32 sysroot a bit. We never backported those below

RFR: 8331552: Update to use jtreg 7.4

2024-06-14 Thread Christian Stein
Please review the change to update to using `jtreg` **7.4**. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. Testing:

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v32]

2024-06-14 Thread Severin Gehwolf
On Fri, 14 Jun 2024 06:49:34 GMT, Alan Bateman wrote: > Yes, on my list. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2167591811