Re: RFR: 8336343: Add more known sysroot library locations for ALSA

2024-07-29 Thread Magnus Ihse Bursie
On Sat, 13 Jul 2024 16:48:20 GMT, Aleksey Shipilev wrote: > Following [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), it > would be more convenient to search into more paths in sysroot for ALSA as > well. Currently, this is the only thing that is missing for me to build from > the

RFR: 8329471: Remove GTK2

2024-07-29 Thread Alexander Zvegintsev
GTK2 support for Swing/AWT was deprecated for removal in JDK 21. It's being removed because no platform that supports the JDK needs it. Manual and automated testing is green. - Commit messages: - 8329471: Remove GTK2 Changes: https://git.openjdk.org/jdk/pull/20378/files Webrev:

Re: RFR: 8336343: Add more known sysroot library locations for ALSA

2024-07-29 Thread Aleksey Shipilev
On Sun, 28 Jul 2024 22:15:05 GMT, Phil Race wrote: > This looks reasonable to me, but someone from the build team (specifically > @magicus or @erikj79) should approve as well. Thanks! [You are in Build Group too](https://openjdk.org/census#build), Phil :) Anyway, I presume both @magicus and @e

Integrated: 8336342: Fix known X11 library locations in sysroot

2024-07-29 Thread Aleksey Shipilev
On Sat, 13 Jul 2024 13:43:42 GMT, Aleksey Shipilev wrote: > In [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), we added the > search paths for X11 libraries, but they point explicitly to `libX11.so`. > First, this is not really correct, as `x_libraries` would be added to a > search

Re: RFR: 8336342: Fix known X11 library locations in sysroot

2024-07-29 Thread Aleksey Shipilev
On Sun, 28 Jul 2024 22:18:07 GMT, Phil Race wrote: > This is marked as an enhancement but it sure looks like a bug fix to me. Yeah, it is a bug, changed. Given that we have both @prrace and @TheShermanTanker (and me) in build group, we have enough reviews for this one. - PR Comme

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-07-29 Thread Daniel Jeliński
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote: >> We use 2 ParkEvent instances per thread. The ParkEvent objects are never >> freed, but they are recycled when a thread dies, so the number of live >> ParkEvent instances is proportional to the maximum number of threads that >> were li

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-07-29 Thread David Holmes
On Mon, 29 Jul 2024 06:04:52 GMT, Daniel Jeliński wrote: > With the original code, the publisher thread was getting the monitor ~100x > more often than the subscriber thread; with the new code, the publisher > thread gets the monitor 2x more often than the subscriber thread. Okay but still, b