Re: RFR: 8298920: Improve microbenchmark build times [v2]

2024-08-20 Thread Jan Lahoda
> Currently incremental builds for the microbenchmarks may take notable amount > of time, like: > > $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java; > time make test TEST=jaxp:tier1 > Building target 'test' in configuration 'linux-x86_64-server-release' > Compiling up to

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v34]

2024-08-20 Thread Severin Gehwolf
> Please review this patch which adds a jlink mode to the JDK which doesn't > need the packaged modules being present. A.k.a run-time image based jlink. > Fundamentally this patch adds an option to use `jlink` even though your JDK > install might not come with the packaged modules (directory `jm

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-20 Thread Erik Joelsson
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This action was > implemen

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-20 Thread Lutz Schmidt
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This action was > implemen

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-08-20 Thread Andrew Haley
On Thu, 27 Jun 2024 22:03:37 GMT, Mikael Vidstedt wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separa

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2024-08-20 Thread Naoto Sato
On Tue, 20 Aug 2024 09:07:54 GMT, Pavel Rappo wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_pt_BR.propertie

Re: RFR: 8298920: Improve microbenchmark build times

2024-08-20 Thread Daniel Jeliński
On Tue, 20 Aug 2024 14:51:03 GMT, Jan Lahoda wrote: >> also interesting, but probably preexisting, and might be platform-specific >> (tested on Cygwin): >> - compile benchmarks with `make test TEST=jaxp:tier1` >> - edit `test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench.java` >> - touch

Re: RFR: 8298920: Improve microbenchmark build times

2024-08-20 Thread Jan Lahoda
On Tue, 20 Aug 2024 09:02:18 GMT, Daniel Jeliński wrote: >> Currently incremental builds for the microbenchmarks may take notable amount >> of time, like: >> >> $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java; >> time make test TEST=jaxp:tier1 >> Building target 'test'

Integrated: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check

2024-08-20 Thread George Adams
On Wed, 14 Aug 2024 08:52:44 GMT, George Adams wrote: > Adds Alpine build CI job to the GitHub actions matrix. Currently this only > builds hotspot. I can add tests too if people think that would be useful but > for now I've left it as just build. This pull request has now been integrated. Ch

Re: RFR: 8298920: Improve microbenchmark build times

2024-08-20 Thread Magnus Ihse Bursie
On Fri, 16 Aug 2024 12:24:19 GMT, Jan Lahoda wrote: > Currently incremental builds for the microbenchmarks may take notable amount > of time, like: > > $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java; > time make test TEST=jaxp:tier1 > Building target 'test' in configu

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v12]

2024-08-20 Thread duke
On Mon, 19 Aug 2024 15:33:07 GMT, George Adams wrote: >> Adds Alpine build CI job to the GitHub actions matrix. Currently this only >> builds hotspot. I can add tests too if people think that would be useful but >> for now I've left it as just build. > > George Adams has updated the pull reques

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v12]

2024-08-20 Thread Magnus Ihse Bursie
On Mon, 19 Aug 2024 15:33:07 GMT, George Adams wrote: >> Adds Alpine build CI job to the GitHub actions matrix. Currently this only >> builds hotspot. I can add tests too if people think that would be useful but >> for now I've left it as just build. > > George Adams has updated the pull reques

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2024-08-20 Thread Pavel Rappo
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8298920: Improve microbenchmark build times

2024-08-20 Thread Daniel Jeliński
On Fri, 16 Aug 2024 12:24:19 GMT, Jan Lahoda wrote: > Currently incremental builds for the microbenchmarks may take notable amount > of time, like: > > $ touch test/micro/org/openjdk/bench/java/io/BlackholedOutputStream.java; > time make test TEST=jaxp:tier1 > Building target 'test' in configu