On Fri, 30 Aug 2024 16:27:18 GMT, Magnus Ihse Bursie wrote:
> The build system code has unfortunately diverted in some places from the
> conventions as described in
> https://openjdk.org/groups/build/doc/code-conventions.html.
>
> Instead of trying to fix these when touching code nearby, I'd l
On Fri, 30 Aug 2024 16:57:18 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
On Fri, 30 Aug 2024 11:15:23 GMT, Stefan Karlsson wrote:
>> I was thinking the same, but there's a problem with that. If we get a
>> promotion failure in the young gen, we are leaving the dead objects marked
>> as forwarded. Then when the Full GC scans these regions with dead objects it
>> wil
On Fri, 30 Aug 2024 16:57:18 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separately.
>
> This is a new attempt at solving
> [JDK-8329816](ht
On Fri, 30 Aug 2024 16:03:19 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Fri, 30 Aug 2024 11:35:51 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by
The build system code has unfortunately diverted in some places from the
conventions as described in
https://openjdk.org/groups/build/doc/code-conventions.html.
Instead of trying to fix these when touching code nearby, I'd like to make an
effort to fix all issues at once and separately. Increme
On Fri, 30 Aug 2024 15:56:17 GMT, Magnus Ihse Bursie wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> sep
On Fri, 30 Aug 2024 13:50:11 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> README fixes
>
> src/jdk.incubator.vector/linux/native/libsleef/README.md line 29:
>
>> 27: `https://github.com
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separately.
>
> This is a new attempt at solving
> [JDK-8329816](ht
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separately.
>
> This is a new attempt at solving
> [JDK-8329816](ht
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separately.
>
> This is a new attempt at solving
> [JDK-8329816](ht
On Thu, 29 Aug 2024 23:07:16 GMT, Magnus Ihse Bursie wrote:
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separat
On Fri, 30 Aug 2024 10:59:55 GMT, Magnus Ihse Bursie wrote:
> Basically, under the `$(eval $(call SetupJdkLibrary, BUILD_LIBVECTORMATH`
> call, you add the line:
>
> ```
> EXTRA_SRC := libsleef/generated, \
> ```
>
> and that should be it.
Thanks!
> However, I see that you also manipula
On Fri, 30 Aug 2024 09:28:59 GMT, Hamlin Li wrote:
> As there are several folders (generated and upstream) under
> src/jdk.incubator.vector/linux/native/libsleef/ now, what's the recommended
> way to only include generated and skip upstream when compile/build the final
> libsleef.so in that pr
On Thu, 29 Aug 2024 23:07:16 GMT, Magnus Ihse Bursie wrote:
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separat
On Thu, 29 Aug 2024 23:07:16 GMT, Magnus Ihse Bursie wrote:
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
> optimize vector math operations by leveraging the SLEEF library. For legal
> reasons the actual contribution of the SLEEF files needs to be handled
> separat
[JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
optimize vector math operations by leveraging the SLEEF library. For legal
reasons the actual contribution of the SLEEF files needs to be handled
separately.
This is a new attempt at solving
[JDK-8329816](https://bugs.ope
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wall) and use a much
> more fine-grained approach to disabling s
On Thu, 22 Aug 2024 17:12:09 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove hashcode leftovers from SA
>
> src/hotspot/share/gc/serial/defNewGeneration.cpp line 707:
>
>> 705:
On Fri, 30 Aug 2024 11:07:46 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/serial/defNewGeneration.cpp line 707:
>>
>>> 705: } else if (obj->is_forwarded()) {
>>> 706: // To restore the klass-bits in the header.
>>> 707: obj->forward_safe_init_mark();
>>
>> I wonder
On Mon, 26 Aug 2024 02:07:39 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update build to link properly
>
> I understand the cost overhead experienced by any individual Java run may
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Wed, 28 Aug 2024 14:49:26 GMT, Magnus Ihse Bursie wrote:
> From the bug report:
>
> After JDK-8318913, trying to cross-compile to a different endian target than
> the build host is using, will cause the interim image generation to fail:
>
>
> [buildjdk] Creating interim jimage
> Error: spe
On Thu, 29 Aug 2024 09:02:36 GMT, Magnus Ihse Bursie wrote:
> The indentation in the build system should be two spaces for logical indents,
> and four spaces for broken lines, period.
>
> I searched for files starting with an odd number of spaces, and fixed those.
This pull request has now bee
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 30 Aug 2024 07:27:45 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/shared/gcForwarding.cpp line 37:
>>
>>> 35: size_t max_narrow_heap_size = right_n_bits(NumLowBitsNarrow - Shift);
>>> 36: if (UseCompactObjectHeaders && max_heap_size > max_narrow_heap_size *
>>> HeapWordSize)
On Fri, 30 Aug 2024 07:25:54 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>>
>>> 31: void SerialArguments::initialize_heap_flags_and_sizes() {
>>> 32: GenArguments::initialize_heap_flags_and_sizes();
>>> 33: GCForwarding::initialize_flags(MaxNewSize
On Fri, 23 Aug 2024 16:23:19 GMT, Leonid Mesnik wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> make/Images.gmk line 135:
>
>> 133: #
>> 134: # Param1 - VM variant (e.g., server,
On Thu, 22 Aug 2024 17:30:14 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove hashcode leftovers from SA
>
> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>
>> 31: void Se
On Thu, 22 Aug 2024 19:36:00 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix hash shift for 32 bit builds
>
> src/hotspot/share/gc/shared/gcForwarding.cpp line 37:
>
>> 35: size_t ma
34 matches
Mail list logo
