Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-09-22 Thread SWinxy
On Tue, 16 Jul 2024 23:20:03 GMT, Chen Liang wrote: >> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html >> >> People were confused on a few details around fixing windows space names, >> including: >> 1. setshortname can report confusing error message when the director

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread David Holmes
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal

2024-09-22 Thread Alan Bateman
On Fri, 6 Sep 2024 13:16:34 GMT, Kevin Rushforth wrote: >> Looks good. I'll review the CSR when its ready. > >> Looks good. I'll review the CSR when its ready. > > Thanks. > >> The changes to make jdk.jsobject an upgradeable module looks right. > > Thanks for checking. My testing primarily foc

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Julian Waters
On Sun, 22 Sep 2024 13:26:36 GMT, Julian Waters wrote: > As I wrote originally: the patch was tested and it works. Moreover, this > seems to be the way to do per-file cflag optimization level overrides. Ah, I remember what I was thinking of now. I was thinking of using BUILD_LIBJVM_stackMapTab

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Julian Waters
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Julian Waters
On Sun, 22 Sep 2024 11:56:48 GMT, Thomas Stuefe wrote: > Please be more specific. What is "that sort of syntax" you disapprove of? I was referring to the fact that we typically do ifeq (string1, string2) in Makefiles rather than ifeq "string1" "string2" (I probably should have used the GitHub

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v6]

2024-09-22 Thread Thomas Stuefe
On Fri, 20 Sep 2024 16:56:58 GMT, Matias Saavedra Silva wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix bit counts in GCForwarding > > src/hotspot/share/cds/archiveUtils.cpp line 348: > >> 346: old_tag = (i

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Thomas Stuefe
On Sun, 22 Sep 2024 11:02:20 GMT, Julian Waters wrote: >> Trivial change to drop the optimization level (for both fastdebug and >> release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. >> >> This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which >> prevents building

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Julian Waters
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Julian Waters
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Thomas Stuefe
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-09-22 Thread Thomas Stuefe
Trivial change to drop the optimization level (for both fastdebug and release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which prevents building on MacOS. Tested: with patch fastdebug and release builds are green aga