Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v39]

2024-10-14 Thread Martin Doerr
On Tue, 8 Oct 2024 16:30:47 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v11]

2024-10-14 Thread Roman Kennke
On Tue, 1 Oct 2024 15:46:01 GMT, Roman Kennke wrote: >>> Indeed, I could re-enable all tests in: >>> >>> ``` >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java >>> test/hotspot/jtreg/compiler/l

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v11]

2024-10-14 Thread Martin Doerr
On Tue, 1 Oct 2024 15:46:01 GMT, Roman Kennke wrote: >>> Indeed, I could re-enable all tests in: >>> >>> ``` >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java >>> test/hotspot/jtreg/compiler/l

Re: RFR: 8341871: Disable G1 for unsupported platforms after JDK-8334060

2024-10-14 Thread Erik Joelsson
On Mon, 14 Oct 2024 13:08:32 GMT, Aleksey Shipilev wrote: > This implicitly fixes x86-32 builds that fail at runtime, because late > barrier expansion is not implemented for them. I think about this check as > something that we should have done as part of original JDK-8334060. > > The first ve

Re: RFR: 8341871: Disable G1 for unsupported platforms after JDK-8334060

2024-10-14 Thread Martin Doerr
On Mon, 14 Oct 2024 13:08:32 GMT, Aleksey Shipilev wrote: > This implicitly fixes x86-32 builds that fail at runtime, because late > barrier expansion is not implemented for them. I think about this check as > something that we should have done as part of original JDK-8334060. > > The first ve

Re: RFR: 8341871: Disable G1 for unsupported platforms after JDK-8334060

2024-10-14 Thread Aleksey Shipilev
On Mon, 14 Oct 2024 13:08:32 GMT, Aleksey Shipilev wrote: > This implicitly fixes x86-32 builds that fail at runtime, because late > barrier expansion is not implemented for them. I think about this check as > something that we should have done as part of original JDK-8334060. > > The first ve

RFR: 8341871: Disable G1 for unsupported platforms after JDK-8334060

2024-10-14 Thread Aleksey Shipilev
This implicitly fixes x86-32 builds that fail at runtime, because late barrier expansion is not implemented for them. I think about this check as something that we should have done as part of original JDK-8334060. The first version was summarily disabling G1 on platforms not explicitly listed i

Re: RFR: 8341871: Disable G1 for unsupported platforms after JDK-8334060

2024-10-14 Thread Martin Doerr
On Mon, 14 Oct 2024 13:08:32 GMT, Aleksey Shipilev wrote: > This implicitly fixes x86-32 builds that fail at runtime, because late > barrier expansion is not implemented for them. I think about this check as > something that we should have done as part of original JDK-8334060. > > The first ve

Re: RFR: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-14 Thread SendaoYan
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Integrated: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-14 Thread SendaoYan
On Fri, 11 Oct 2024 03:14:40 GMT, SendaoYan wrote: > Hi all, > On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is > mounted as tmpfs filesystem type, this filesystem type doesn't support create > time(birth time). > This PR is a REDO PR of https://github.com/openjdk/jd

Re: RFR: 8339570: Add Tidy build support for JDK tests [v7]

2024-10-14 Thread Magnus Ihse Bursie
On Mon, 14 Oct 2024 11:04:44 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v6]

2024-10-14 Thread Magnus Ihse Bursie
On Mon, 14 Oct 2024 08:35:18 GMT, Nizar Benalla wrote: > I dropped the `test-docs` make target, until I can add a better way of > passing the dependency. Do you think you can implement the `TEST_DEPS` solution as sketched by me above, or do you need my help to do it? - PR Comment

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v7]

2024-10-14 Thread Nizar Benalla
On Mon, 14 Oct 2024 11:00:09 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8339570: Add Tidy build support for JDK tests [v7]

2024-10-14 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v6]

2024-10-14 Thread Nizar Benalla
On Mon, 14 Oct 2024 08:28:03 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v7]

2024-10-14 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8337536: AArch64: Enable BTI branch protection for runtime part [v3]

2024-10-14 Thread Fei Gao
On Tue, 3 Sep 2024 09:25:55 GMT, Andrew Haley wrote: >> Fei Gao has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> since

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v6]

2024-10-14 Thread Nizar Benalla
On Mon, 14 Oct 2024 08:28:03 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v5]

2024-10-14 Thread Nizar Benalla
On Fri, 11 Oct 2024 15:46:19 GMT, Magnus Ihse Bursie wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add tidy as a dependency to `run-test-prebuilt-docs` and `docs` profiles > > test/docs/TEST.ROOT line 12: > >>

Re: RFR: 8339570: Add Tidy build support for JDK tests [v6]

2024-10-14 Thread Nizar Benalla
On Mon, 14 Oct 2024 08:25:49 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v6]

2024-10-14 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8339570: Add Tidy build support for JDK tests [v6]

2024-10-14 Thread Nizar Benalla
> Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependency is primarily going to be used to test the generated