Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2024-12-11 Thread Julian Waters
On Wed, 11 Dec 2024 20:55:41 GMT, Magnus Ihse Bursie wrote: >> @magicus Sorry for the ping, but I'm a bit confused. Do you know what bug >> report site Phil is referring to when he says to submit a bug to AWT >> instead? Is it just the JBS? (There's a little bit of a problem if it is, it >> is

Re: Hermetic Java: OnLoad_ changes

2024-12-11 Thread Jiangli Zhou
Hi Magnus, Thanks for looking into this. I have been working on our internal prototype to integrate https://github.com/openjdk/jdk/pull/20837 changes. Integration has been already done and I have uncovered a couple of issues so far, https://bugs.openjdk.org/browse/JDK-8345744 and https://bugs.open

Hermetic Java: OnLoad_ changes

2024-12-11 Thread Magnus Ihse Bursie
I've tried to extract the changes in the hermetic-java-runtime branch that relates to the OnLoad_ changes. It turns out that it was some time since the last merge of master into this branch, so there were quite a few conflicts due to the changes in these areas lately. I think I have solved the

Integrated: 8345683: Remove special flags for files compiled for static libraries

2024-12-11 Thread Magnus Ihse Bursie
On Fri, 6 Dec 2024 15:04:42 GMT, Magnus Ihse Bursie wrote: > For various reasons, we have added some extra flags to the compiler command > line when compiling C/C++ for static libraries. This is a blocker for the > goal of compiling once, linking twice for static and dynamic library. > Fortuna

Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2024-12-11 Thread Magnus Ihse Bursie
On Wed, 11 Dec 2024 06:20:07 GMT, Julian Waters wrote: >> Then you'll have to create a macro for disabling the unused warnings >> (however, I'm not sure how well that would be received). Or fix the bug if >> it is actually unused. Or wait until we go to 17. > > @magicus Sorry for the ping, but

Re: RFR: 8343832: Enhance test summary with number of skipped tests [v4]

2024-12-11 Thread Ivan Bereziuk
> The output for Jtreg v7.5 was > [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) > with [information about skipped > tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#wh

Re: RFR: 8341097: GHA: Demote Mac x86 jobs to build only [v3]

2024-12-11 Thread Aleksey Shipilev
On Tue, 10 Dec 2024 19:24:59 GMT, Aleksey Shipilev wrote: >> See the discussion in the bug. I think we can stop testing Mac x86 in GHA, >> leaving only the build jobs. >> >> Additional testing: >> - [x] GHA passes > > Aleksey Shipilev has updated the pull request with a new target base due to

Re: RFR: 8345683: Remove special flags for files compiled for static libraries

2024-12-11 Thread Erik Joelsson
On Fri, 6 Dec 2024 15:04:42 GMT, Magnus Ihse Bursie wrote: > For various reasons, we have added some extra flags to the compiler command > line when compiling C/C++ for static libraries. This is a blocker for the > goal of compiling once, linking twice for static and dynamic library. > Fortuna