On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Sun, 27 Apr 2025 22:22:02 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Mon, 28 Apr 2025 20:10:19 GMT, Magnus Ihse Bursie wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains nine commits:
>>
>> - Merge branch 'master' into JDK-8350209
>> - Downgraded UL as asked. Added synch
On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Mon, 28 Apr 2025 19:30:23 GMT, Magnus Ihse Bursie wrote:
>> kuaiwei has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Get SDK_INSTALL_DIR from enviroment variable
>
> make/devkit/createWindowsDevkit.sh line 69:
>
>> 67: elif test "x$IS
> The patch fix error when creating devkit on wsl/msys2 .
> * Msys2 can be supported like cygwin
> * In wsl, it can not test path name in windows format, like `if [ -d
> "d:/VisualStuio"]` . The path must be converted as linux style before testing.
> * In msys2, `cmd.exe /c` doesn't work because "
On Mon, 28 Apr 2025 16:19:09 GMT, Frederic Thevenet
wrote:
> **Please note that this is not a formal review, as I am not an OpenJDK
> reviewer.**
>
> `createWindowsDevkit.sh` will fail to run when MSYS2 is started under any
> other environment[1] other than "MSYS" (i.e. `MINGW64`, `UCRT64`, `
On Mon, 28 Apr 2025 20:33:25 GMT, Magnus Ihse Bursie wrote:
> With that said, it is very much unclear why this line is here at all. The
> removal of xml files is from the original integration of microbenchmarks,
> JDK-8061281, and the reason behind it is lost in time.
As I wrote above:
>The r
On Mon, 28 Apr 2025 20:08:00 GMT, Magnus Ihse Bursie wrote:
> Are we sure powershell is always installed on Windows?
I verified by running tests on all the Windows versions we use internally and
looked at the calculated concurrency in RunTest.gmk. If we didn't get a number
for memory I believe
On Mon, 28 Apr 2025 08:30:43 GMT, Maurizio Cimadamore
wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into
>> JDK-8355080
>> - Address henryjen@ c
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get
> the `default.instruments.template.xml` file bundled in the JMH core jar to
> support xtrace profiler.
With that said, it is very much unclear why this line
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get
> the `default.instruments.template.xml` file bundled in the JMH core jar to
> support xtrace profiler.
My understanding here is that we unpack four differen
On Thu, 17 Apr 2025 07:28:03 GMT, Julian Waters wrote:
> The src/hotspot directory should ideally only be used for HotSpot source
> files, and we should avoid polluting it with an .editorconfig. A cleaner
> solution exists since we can just specify the desired code formatting for
> HotSpot as
On Sun, 27 Apr 2025 22:22:02 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote:
>> After searching the entire JDK source code, I found that WMIC is only used
>> in four files. These WMIC calls can be replaced with PowerShell for WMI.
>>
>> The primary challenge in this replacement is to make it work the same as
>> bef
I thought I recognized this issue, and started searching the mail
archive. Seems the same question was asked last year by ... you. :-)
https://mail.openjdk.org/pipermail/build-dev/2024-August/046011.html
I guess nobody still has a simple answer to give you. I don't understand
how the msan inte
On Mon, 28 Apr 2025 08:30:43 GMT, Maurizio Cimadamore
wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into
>> JDK-8355080
>> - Address henryjen@ c
On Mon, 28 Apr 2025 18:22:13 GMT, Jiangli Zhou wrote:
> Please review this PR that adds the static-jdk-bundles make target. The
> static-jdk-bundles is needed by JDK-8355452
> (https://bugs.openjdk.org/browse/JDK-8355452) for adding tier1 tests on
> linux-x64 static-jdk in GHA.
This pull requ
On Fri, 25 Apr 2025 06:24:31 GMT, Amit Kumar wrote:
> updated march level from z10 to z13.
>
> Testing: tier1 (fastdebug-vm)
This is a failure when building the gtest framework.
Could this different arch flag be sensitive to different gcc versions? When you
say you tested locally, what gcc v
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store me
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Mon, 28 Apr 2025 19:24:04 GMT, Magnus Ihse Bursie wrote:
>> Please review this PR that adds the static-jdk-bundles make target. The
>> static-jdk-bundles is needed by JDK-8355452
>> (https://bugs.openjdk.org/browse/JDK-8355452) for adding tier1 tests on
>> linux-x64 static-jdk in GHA.
>
> M
On Mon, 28 Apr 2025 15:22:50 GMT, Matthias Baesken wrote:
> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or
> Linux), we get the following warnings :
>
>
> warning: unknown warning option '-Wno-stringop-truncation'; did you mean
> '-Wno-string-concatenation'? [-W
On Mon, 28 Apr 2025 18:22:13 GMT, Jiangli Zhou wrote:
> Please review this PR that adds the static-jdk-bundles make target. The
> static-jdk-bundles is needed by JDK-8355452
> (https://bugs.openjdk.org/browse/JDK-8355452) for adding tier1 tests on
> linux-x64 static-jdk in GHA.
Marked as revi
On Mon, 28 Apr 2025 13:04:57 GMT, Jorn Vernee wrote:
> > Having to upgrade to JNI is a bit sad -- although I get that it is required
> > as a workaround for now. For the longer term I'd prefer a better way to
> > integrate static lookups in the FFM API. For instance, all
> > `JNI::loadLibrary`
On Tue, 22 Apr 2025 21:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that changes to use `NativeLibraries.loadLibrary()` for
> loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>
> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> bu
On Mon, 28 Apr 2025 08:30:43 GMT, Maurizio Cimadamore
wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'JDK-8355080' of ssh://github.com/jianglizhou/jdk into
>> JDK-8355080
>> - Address henryjen@ c
Please review this PR that adds the static-jdk-bundles make target. The
static-jdk-bundles is needed by JDK-8355452
(https://bugs.openjdk.org/browse/JDK-8355452) for adding tier1 tests on
linux-x64 static-jdk in GHA.
-
Commit messages:
- Add static-jdk-bundles make target.
Change
On Mon, 28 Apr 2025 17:35:13 GMT, Vladimir Kozlov wrote:
> Looks better. There are still places where UL is used specifically for TD
> processing. Consider using `(aot, training)` there instead of `(cds)`.
Right. I haven't addressed these review comments yet.
-
PR Comment: https:/
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store me
On Mon, 28 Apr 2025 15:17:06 GMT, Mikael Vidstedt wrote:
>> Oracle is updating the version of Visual Studio for building the JDK on
>> Windows to Visual Studio 2022 17.13.2.
>>
>> Testing: tier1-5
>
> Mikael Vidstedt has updated the pull request with a new target base due to a
> merge or a reb
On Thu, 17 Apr 2025 01:17:50 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.13.2.
>
> Testing: tier1-5
This pull request has now been integrated.
Changeset: a090aa3f
Author:Mikael Vidstedt
URL:
On Mon, 28 Apr 2025 15:22:50 GMT, Matthias Baesken wrote:
> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or
> Linux), we get the following warnings :
>
>
> warning: unknown warning option '-Wno-stringop-truncation'; did you mean
> '-Wno-string-concatenation'? [-W
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
XCode 16.2 worked fine for me. I also see the same warnings with XCode 16.3.
You can manually download XCode via
http://developer.apple.com/download/all/?q=Xcode. XCode 16.2 is still there
right now. Downloading it, unzipping it and putting elsewhere other than
/Applications might work if used alo
On Mon, 28 Apr 2025 15:22:50 GMT, Matthias Baesken wrote:
> When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or
> Linux), we get the following warnings :
>
>
> warning: unknown warning option '-Wno-stringop-truncation'; did you mean
> '-Wno-string-concatenation'? [-W
When building ubsan-enabled binaries with the clang toolchain (e.g. on AIX or
Linux), we get the following warnings :
warning: unknown warning option '-Wno-stringop-truncation'; did you mean
'-Wno-string-concatenation'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-format-ove
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.13.2.
>
> Testing: tier1-5
Mikael Vidstedt has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought
On Tue, 15 Apr 2025 18:40:57 GMT, Joachim Kern wrote:
> With the introduction of the open XL 17.1.2.13 Compiler and the runtime
> 17.1.3 as minimum requirement ubsan is supported for AIX now.
> Unfortunately there has to be some adoptions.
> - Currently the test for vptr does not work and produc
On Thu, 17 Apr 2025 15:42:09 GMT, Joachim Kern wrote:
>> With the introduction of the open XL 17.1.2.13 Compiler and the runtime
>> 17.1.3 as minimum requirement ubsan is supported for AIX now.
>> Unfortunately there has to be some adoptions.
>> - Currently the test for vptr does not work and pr
> Perf numbers for simple main:
> Linking of `Class::forName0` down from ~152 to ~83
>
> For calling little color management system
> https://bugs.openjdk.org/browse/JDK-8313344:
> JNI: ~45
> baseline panama: ~164
> patch: ~103
>
> Also see #24705.
Chen Liang has updated the pull request with a
On Thu, 17 Apr 2025 15:42:09 GMT, Joachim Kern wrote:
>> With the introduction of the open XL 17.1.2.13 Compiler and the runtime
>> 17.1.3 as minimum requirement ubsan is supported for AIX now.
>> Unfortunately there has to be some adoptions.
>> - Currently the test for vptr does not work and pr
On Mon, 28 Apr 2025 13:50:17 GMT, Chen Liang wrote:
>> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 184:
>>
>>> 182: ADDRESS, ADDRESS, ADDRESS,
>>> 183: JAVA_BOOLEAN, ADDRESS, ADDRESS);
>>> 184: Linker.nativeLinker().downcallHandle(s
On Mon, 28 Apr 2025 01:43:32 GMT, Chen Liang wrote:
> Transforms can run on a stream of class file elements. Currently, that stream
> can only be from a CompoundElement. We can allow a ClassFileBuilder to
> provide such a stream too; a recent request
> https://mail.openjdk.org/pipermail/classf
On Mon, 28 Apr 2025 01:43:32 GMT, Chen Liang wrote:
> Transforms can run on a stream of class file elements. Currently, that stream
> can only be from a CompoundElement. We can allow a ClassFileBuilder to
> provide such a stream too; a recent request
> https://mail.openjdk.org/pipermail/classf
On Mon, 28 Apr 2025 13:40:47 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify FFM linker warmup
>
> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 184:
>
>> 182:
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Fri, 18 Apr 2025 18:25:54 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
On Mon, 28 Apr 2025 09:15:28 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store me
> The patch fix error when creating devkit on wsl/msys2 .
> * Msys2 can be supported like cygwin
> * In wsl, it can not test path name in windows format, like `if [ -d
> "d:/VisualStuio"]` . The path must be converted as linux style before testing.
> * In msys2, `cmd.exe /c` doesn't work because "
On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Mon, 28 Apr 2025 08:30:43 GMT, Maurizio Cimadamore
wrote:
> Having to upgrade to JNI is a bit sad -- although I get that it is required
> as a workaround for now. For the longer term I'd prefer a better way to
> integrate static lookups in the FFM API. For instance, all `JNI::loadLibrary`
On Mon, 28 Apr 2025 09:41:38 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/spec.gmk.template line 173:
>>
>>> 171:
>>> 172: # dev or ci
>>> 173: BUILD_ENV := @BUILD_ENV@
>>
>> I think the `BUILD_ENV` could be seted in command line also. So, should we
>> update the doc/building.md sync with
On Mon, 28 Apr 2025 11:51:23 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify FFM linker warmup
>
> src/java.base/share/classes/jdk/internal/foreign/abi/NativeEntryPoint.java
> line
On Fri, 18 Apr 2025 18:25:54 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
The patch fix error when creating devkit on wsl/msys2 .
* Msys2 can be supported like cygwin
* In wsl, it can not test path name in windows format, like `d:/VisualStuio` .
The path must be converted as linux style.
* In msys2, `cmd.exe /c` doesn't work because "/c" is converted as "c:", it can
be
On Thu, 24 Apr 2025 20:55:33 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of Xcode for building the JDK on macOS to
> Xcode 15.4.
>
> Testing: tier1-5
Marked as reviewed by ihse (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24862#pullrequestreview-2798
On Thu, 17 Apr 2025 01:17:50 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.13.2.
>
> Testing: tier1-5
Marked as reviewed by ihse (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24
On Mon, 21 Apr 2025 22:51:33 GMT, Mikael Vidstedt wrote:
> Traditionally, when upgrading the versions of the components (gcc, binutils,
> etc.) in Tools.gmk, the old versions/definitions have been preserved. The
> list is now starting to be on the long side, it's unlikely that anybody would
>
On Thu, 3 Apr 2025 14:48:58 GMT, Hannes Wallnöfer wrote:
> Please review a change to add a `javadoc` option to enable syntax
> highlighting for code fragments in snippets and `` tags. The new
> `--syntax-highlight` option uses the [highlight.js] JavaScript library and
> supports Java, Propert
On Sun, 20 Apr 2025 04:01:31 GMT, SendaoYan wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into make-doctor-on-ci
>> - 8345874: Run make doctor automatical
On Mon, 28 Apr 2025 01:43:32 GMT, Chen Liang wrote:
> Transforms can run on a stream of class file elements. Currently, that stream
> can only be from a CompoundElement. We can allow a ClassFileBuilder to
> provide such a stream too; a recent request
> https://mail.openjdk.org/pipermail/classf
> Improve warm-up time by making profile data from a previous run of an
> application instantly available, when the HotSpot Java Virtual Machine
> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
> to store method execution profiles from training runs, reducing profili
> Improve warm-up time by making profile data from a previous run of an
> application instantly available, when the HotSpot Java Virtual Machine
> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
> to store method execution profiles from training runs, reducing profili
On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
66 matches
Mail list logo
