Re: RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm

2025-07-28 Thread Aleksey Shipilev
On Wed, 23 Jul 2025 16:20:52 GMT, Aleksey Shipilev wrote: > I have noticed that GHA jobs started to fail when creating ppc64el sysroot. > We are using Debian bullseye as the base for sysroots. Debian bullseye is LTS > release. Perhaps counter-intuitively, LTS platform support shrinks over the

Re: RFR: 8362885: A more formal way to mark javac's Flags that belong to a specific Symbol type only [v3]

2025-07-28 Thread Chen Liang
On Mon, 28 Jul 2025 06:50:47 GMT, Jan Lahoda wrote: >> This PR proposes to improve handling of javac's `Flags` in two ways: >> - for each flag, there's now an informational annotation specifying what is >> the target Symbol type. Only targets right now are `TypeSymbol`s, >> `MethodSymbol`s and

Re: RFR: 8362885: A more formal way to mark javac's Flags that belong to a specific Symbol type only [v2]

2025-07-28 Thread Jan Lahoda
On Fri, 25 Jul 2025 14:38:18 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Fixing toString value for flags that have ACC_ overloaded flags. >> - Review feedback: marking ACC flags wit

Re: RFR: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Fei Gao
On Mon, 28 Jul 2025 10:36:16 GMT, Fei Gao wrote: >> @fg1417 -- want to pull it to `jdk25u`? I think it is not a showstopper for >> JDK 25 GA, so we can get it into `25.0.1`. > > @shipilev thanks for your reminder! I'll backport it to` jdk25u` soon. > Hello @fg1417, we see build failures in our

Integrated: 8364185: [BACKOUT] AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Jaikiran Pai
On Mon, 28 Jul 2025 10:40:18 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backs out the changes done in > https://bugs.openjdk.org/browse/JDK-8363063? The linux-aarch64 builds in our > CI started failing after the changes in JDK-8363063 were integrated. > > The de

Re: RFR: 8364185: [BACKOUT] AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Jaikiran Pai
On Mon, 28 Jul 2025 10:46:32 GMT, Albert Mingkun Yang wrote: >> Can I please get a review of this change which backs out the changes done in >> https://bugs.openjdk.org/browse/JDK-8363063? The linux-aarch64 builds in our >> CI started failing after the changes in JDK-8363063 were integrated. >

RFR: 8364185: [BACKOUT] AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Jaikiran Pai
Can I please get a review of this change which backs out the changes done in https://bugs.openjdk.org/browse/JDK-8363063? The linux-aarch64 builds in our CI started failing after the changes in JDK-8363063 were integrated. The description in the backout issue https://bugs.openjdk.org/browse/JD

Re: RFR: 8364185: [BACKOUT] AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Albert Mingkun Yang
On Mon, 28 Jul 2025 10:40:18 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backs out the changes done in > https://bugs.openjdk.org/browse/JDK-8363063? The linux-aarch64 builds in our > CI started failing after the changes in JDK-8363063 were integrated. > > The de

Re: RFR: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Jaikiran Pai
On Mon, 28 Jul 2025 10:36:16 GMT, Fei Gao wrote: >> @fg1417 -- want to pull it to `jdk25u`? I think it is not a showstopper for >> JDK 25 GA, so we can get it into `25.0.1`. > > @shipilev thanks for your reminder! I'll backport it to` jdk25u` soon. Hello @fg1417, we see build failures in our CI

Re: RFR: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Fei Gao
On Mon, 28 Jul 2025 09:41:28 GMT, Aleksey Shipilev wrote: >> Thanks for your approval @theRealAph @shipilev ! > > @fg1417 -- want to pull it to `jdk25u`? I think it is not a showstopper for > JDK 25 GA, so we can get it into `25.0.1`. @shipilev thanks for your reminder! I'll backport it to` jdk

RFR: 8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

2025-07-28 Thread Ao Qi
After [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004), the following code was added. #ifndef PNG_LOONGARCH_LSX_OPT # if defined(__loongarch_sx) # define PNG_LOONGARCH_LSX_OPT 1 # else # define PNG_LOONGARCH_LSX_OPT 0 # endif #endif Some compilers on LoongArch64 platforms enable `__l

Re: RFR: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Aleksey Shipilev
On Mon, 28 Jul 2025 08:43:25 GMT, Fei Gao wrote: >> Marked as reviewed by aph (Reviewer). > > Thanks for your approval @theRealAph @shipilev ! @fg1417 -- want to pull it to `jdk25u`? I think it is not a showstopper for JDK 25 GA, so we can get it into `25.0.1`. - PR Comment: https

Re: RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm

2025-07-28 Thread Aleksey Shipilev
On Fri, 25 Jul 2025 08:12:51 GMT, Aleksey Shipilev wrote: > Thanks! More reviews, please? Ping :) - PR Comment: https://git.openjdk.org/jdk/pull/26447#issuecomment-3126292006

Re: RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm

2025-07-28 Thread Aleksey Shipilev
On Wed, 23 Jul 2025 16:20:52 GMT, Aleksey Shipilev wrote: > I have noticed that GHA jobs started to fail when creating ppc64el sysroot. > We are using Debian bullseye as the base for sysroots. Debian bullseye is LTS > release. Perhaps counter-intuitively, LTS platform support shrinks over the

Re: RFR: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Fei Gao
On Fri, 25 Jul 2025 08:09:45 GMT, Andrew Haley wrote: >> This patch fixes a typo introduced in >> [JDK-8353217](https://github.com/openjdk/jdk/commit/130b0cdaa6604da47a893e5425547acf3d5253f4), >> which incorrectly disabled SVE vector math symbols. As a result, some >> vector math test cases su

Integrated: 8363063: AArch64: [VectorAPI] sve vector math operations are not supported after JDK-8353217

2025-07-28 Thread Fei Gao
On Thu, 24 Jul 2025 16:02:41 GMT, Fei Gao wrote: > This patch fixes a typo introduced in > [JDK-8353217](https://github.com/openjdk/jdk/commit/130b0cdaa6604da47a893e5425547acf3d5253f4), > which incorrectly disabled SVE vector math symbols. As a result, some vector > math test cases such as `jd