On Fri, 8 Aug 2025 06:30:16 GMT, Thomas Stuefe wrote:
>> https://github.com/openjdk/jdk/commit/0054bbed7fce5b8566655d6910b09b10c952e609
>> (from https://bugs.openjdk.org/browse/JDK-8343756) caused the gtest death
>> tests to fail on Windows with the error message "Caught
>> std::exception-deri
On Fri, 8 Aug 2025 00:43:27 GMT, Francesco Andreuzzi wrote:
>> In this PR I propose to refresh the included headers in hotspot
>> `precompiled.hpp`. The current set of precompiled headers was refreshed in
>> 2018, 7 years ago. I repeated the same operations and measurements after
>> refreshing
On Wed, 6 Aug 2025 18:05:24 GMT, Saint Wesonga wrote:
> https://github.com/openjdk/jdk/commit/0054bbed7fce5b8566655d6910b09b10c952e609
> (from https://bugs.openjdk.org/browse/JDK-8343756) caused the gtest death
> tests to fail on Windows with the error message "Caught
> std::exception-derived
On Thu, 7 Aug 2025 00:24:10 GMT, Kim Barrett wrote:
> How is it that we (Oracle) don't see these gtest death test failures in our
> CI? I'm guessing others (like SAP - @tstuefe ?) aren't either, since this
> issue is newly reported while the causing change was made more than 8 months
> ago.
>
On Thu, 7 Aug 2025 14:17:32 GMT, Roger Riggs wrote:
> It looks like I created a merge conflict by asking to fix these. Another PR
> https://git.openjdk.org/jdk/pull/26667 is also changing them. (At the time
> the other PR had not started). The least chaos may be created by backing out
> those
> A customer reported an error where a well-known system library, upon loading
> into the JVM process (via a longish indirect dependency chain), changed the
> signal disposition of the process for SIGPIPE to SIG_IGN. This gets inherited
> down to child processes, where it caused child processes
On Thu, 7 Aug 2025 19:55:35 GMT, Francesco Andreuzzi wrote:
> For example, when the threshold is set to 50 I get this compilation error:
How can we possibly get a compilation error when everything should build with
PCH disabled?
-
PR Comment: https://git.openjdk.org/jdk/pull/26681
On Fri, 8 Aug 2025 00:43:27 GMT, Francesco Andreuzzi wrote:
>> In this PR I propose to refresh the included headers in hotspot
>> `precompiled.hpp`. The current set of precompiled headers was refreshed in
>> 2018, 7 years ago. I repeated the same operations and measurements after
>> refreshing
On Thu, 7 Aug 2025 21:08:03 GMT, Erik Joelsson wrote:
>> src/jdk.jpackage/windows/native/libwixhelper/libmsica.cpp line 1:
>>
>>> 1: /*
>>
>> Should we rename directory name as well?
>
> Without renaming the directory, I'm wondering how this could build at all.
Good catch!
-
PR R
> In this PR I propose to refresh the included headers in hotspot
> `precompiled.hpp`. The current set of precompiled headers was refreshed in
> 2018, 7 years ago. I repeated the same operations and measurements after
> refreshing the set of precompiled headers according to the current usage
>
On Thu, 7 Aug 2025 13:14:42 GMT, Erik Joelsson wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> makefiles fixed
>
> make/RunTests.gmk line 64:
>
>> 62:
>> 63: AGENT_PREFIX := lib
>> 64: AGENT_EXT := .so
>
> We a
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and more are coming. I want to push the agent so it is
> po
On Thu, 7 Aug 2025 20:45:27 GMT, Alexander Matveev wrote:
>> Rename "libwixhelper" in "libmsica".
>
> src/jdk.jpackage/windows/native/libwixhelper/libmsica.cpp line 1:
>
>> 1: /*
>
> Should we rename directory name as well?
Without renaming the directory, I'm wondering how this could build at
On Thu, 7 Aug 2025 18:38:10 GMT, Alexey Semenyuk wrote:
> Rename "libwixhelper" in "libmsica".
src/jdk.jpackage/windows/native/libwixhelper/libmsica.cpp line 1:
> 1: /*
Should we rename directory name as well?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26682#discussion
On Thu, 7 Aug 2025 18:38:10 GMT, Alexey Semenyuk wrote:
> Rename "libwixhelper" in "libmsica".
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26682#pullrequestreview-3098606661
Rename "libwixhelper" in "libmsica".
-
Commit messages:
- 8364129: Rename libwixhelper
Changes: https://git.openjdk.org/jdk/pull/26682/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26682&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8364129
Stats: 11 lines in 5
On Thu, 7 Aug 2025 17:32:35 GMT, Aleksey Shipilev wrote:
> Also, maybe check in the generation script as well? I think a subfolder here
> would be fine: https://github.com/openjdk/jdk/tree/master/src/utils. It would
> be nice if the output of that script could be simply piped into
> `precompil
On Thu, 7 Aug 2025 18:51:04 GMT, Francesco Andreuzzi wrote:
>> In this PR I propose to refresh the included headers in hotspot
>> `precompiled.hpp`. The current set of precompiled headers was refreshed in
>> 2018, 7 years ago. I repeated the same operations and measurements after
>> refreshing
On Thu, 7 Aug 2025 18:44:29 GMT, Francesco Andreuzzi wrote:
>> src/hotspot/share/precompiled/precompiled.hpp line 29:
>>
>>> 27:
>>> 28: // These header files are included in at least 130 C++ files, as of
>>> 29: // measurements made in November 2018. This list excludes files named
>>
>> Keep
> In this PR I propose to refresh the included headers in hotspot
> `precompiled.hpp`. The current set of precompiled headers was refreshed in
> 2018, 7 years ago. I repeated the same operations and measurements after
> refreshing the set of precompiled headers according to the current usage
>
On Thu, 7 Aug 2025 17:07:17 GMT, Aleksey Shipilev wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> keep comment
>
> src/hotspot/share/precompiled/precompiled.hpp line 29:
>
>> 27:
>> 28: // These header fil
On Thu, 7 Aug 2025 16:47:04 GMT, Francesco Andreuzzi wrote:
> In this PR I propose to refresh the included headers in hotspot
> `precompiled.hpp`. The current set of precompiled headers was refreshed in
> 2018, 7 years ago. I repeated the same operations and measurements after
> refreshing the
On Thu, 7 Aug 2025 16:47:04 GMT, Francesco Andreuzzi wrote:
> In this PR I propose to refresh the included headers in hotspot
> `precompiled.hpp`. The current set of precompiled headers was refreshed in
> 2018, 7 years ago. I repeated the same operations and measurements after
> refreshing the
On Thu, 7 Aug 2025 00:24:10 GMT, Kim Barrett wrote:
> I was concerned that this might effectively undo JDK-8185734, since the
> suggestion in JBS was to conditionalize some code on GTEST_HAS_SEH being
> true. But it looks like the actual change didn't do that.
Thanks for pointing this out. Let
On Thu, 7 Aug 2025 00:24:10 GMT, Kim Barrett wrote:
> The code in gtest-death-test-internal.h#L198-L212 referenced in the PR
> description is conditionalized on GTEST_HAS_EXCEPTIONS, which leads me to
> wonder why exceptions are enabled. If not for that, we wouldn't be in that
> code.
>
> Tha
On Wed, 9 Jul 2025 22:28:56 GMT, Daniel Hu wrote:
>> These changes should prevent entire binary files from being loaded into
>> memory for build/AbsPathsInImage.java test. I chose a default buffer size of
>> 8KB since BufferedInputStream uses that, but open to alternative solutions.
>> GHA pas
On Thu, 7 Aug 2025 16:47:04 GMT, Francesco Andreuzzi wrote:
> In this PR I propose to refresh the included headers in hotspot
> `precompiled.hpp`. The current set of precompiled headers was refreshed in
> 2018, 7 years ago. I repeated the same operations and measurements after
> refreshing the
In this PR I propose to refresh the included headers in hotspot
`precompiled.hpp`. The current set of precompiled headers was refreshed in
2018, 7 years ago. I repeated the same operations and measurements after
refreshing the set of precompiled headers according to the current usage
frequency.
On Thu, 7 Aug 2025 06:54:42 GMT, Thomas Stuefe wrote:
>> A customer reported an error where a well-known system library, upon loading
>> into the JVM process (via a longish indirect dependency chain), changed the
>> signal disposition of the process for SIGPIPE to SIG_IGN. This gets
>> inherit
On Thu, 17 Jul 2025 02:39:15 GMT, Leonid Mesnik wrote:
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and
30 matches
Mail list logo
