Re: RFR: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-02 Thread Erik Joelsson
On Tue, 2 Sep 2025 12:30:25 GMT, Aleksey Shipilev wrote: > Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but > switching to Debian trixie. We have waited for about a month for it to > stabilize, and it seems good to switch now. The benefit of doing this now is > making RI

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-02 Thread Claes Redestad
On Tue, 2 Sep 2025 22:20:26 GMT, Chen Liang wrote: >> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird >> state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, >> run it as a main class, and paste the generated VarHandleGuards class. >> >> This p

Re: RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-02 Thread Kim Barrett
On Tue, 2 Sep 2025 23:25:43 GMT, Kim Barrett wrote: > Please review this change to offset_of to just use offsetof as it's > implementation. The rationale for this is > > (1) Despite being UB for some cases that we use (through C++14), none of the > compilers we use actually treat it as such, oth

Integrated: 8366195: Remove unnecessary quotes around -Ta ml64 assembler argument

2025-09-02 Thread Saint Wesonga
On Sat, 30 Aug 2025 15:34:00 GMT, Saint Wesonga wrote: > This PR cleans up the handling of the -Ta argument by removing the quotes > that were unintentionally added around the argument and moving the > declaration of the argument to match -Fo as suggested in > https://github.com/openjdk/jdk/pu

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build [v2]

2025-09-02 Thread Chen Liang
> Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird > state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, > run it as a main class, and paste the generated VarHandleGuards class. > > This process is complex and error-prone, and having a huge chunk

Re: RFR: 8366195: Remove unnecessary quotes around -Ta ml64 assembler argument

2025-09-02 Thread Erik Joelsson
On Sat, 30 Aug 2025 15:34:00 GMT, Saint Wesonga wrote: > This PR cleans up the handling of the -Ta argument by removing the quotes > that were unintentionally added around the argument and moving the > declaration of the argument to match -Fo as suggested in > https://github.com/openjdk/jdk/pu

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build

2025-09-02 Thread Paul Sandoz
On Fri, 29 Aug 2025 19:13:27 GMT, Chen Liang wrote: > Currently, java.lang.invoke.VarHandles$GuardMethodGenerator is in a weird > state: when VarHandleGuards needs to be updated, we uncomment it, build JDK, > run it as a main class, and paste the generated VarHandleGuards class. > > This proce

Re: RFR: 8366455: Move VarHandles.GuardMethodGenerator to execute on build

2025-09-02 Thread Paul Sandoz
On Mon, 1 Sep 2025 16:57:35 GMT, Jorn Vernee wrote: > @PaulSandoz Do you know if there was/is a particular reason for not > generating the VarHandle guards as part of the build? At the time there were other priorities and we did not know what the frequency of updates might be, but we left gen

Re: RFR: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-02 Thread Fei Yang
On Tue, 2 Sep 2025 12:30:25 GMT, Aleksey Shipilev wrote: > Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but > switching to Debian trixie. We have waited for about a month for it to > stabilize, and it seems good to switch now. The benefit of doing this now is > making RI

Integrated: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1

2025-09-02 Thread Leo Korinth
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote: > This changes the timeout factor from 4 to 1. Most of the changes add timeouts > to individual test cases so that I am able to run them with a timeout factor > of 0.7 (some margin to the checked in factor of one) > > In addition to changing