Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64

2025-09-03 Thread SendaoYan
On Wed, 3 Sep 2025 14:51:31 GMT, Aleksey Shipilev wrote: > In our case, it was the old crosstools-ng generated toolchain. Have you seen > this on some standard toolchain? I observed this failure on ubuntu18 with gcc10 and the system-native bintuils toolchain. The gcc10 was installed from ppa:u

Re: RFR: 8314488: Compiling the JDK with C++17 [v4]

2025-09-03 Thread Ivan Walulya
On Mon, 25 Aug 2025 23:31:03 GMT, Kim Barrett wrote: >> Please review this change to use C++17 for building C++ parts of the JDK. In >> particular this affects HotSpot. This change also includes an update to the >> HotSpot Style Guide regarding C++17 features and their use in HotSpot code. >> >>

Integrated: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Kim Barrett
On Tue, 2 Sep 2025 23:25:43 GMT, Kim Barrett wrote: > Please review this change to offset_of to just use offsetof as it's > implementation. The rationale for this is > > (1) Despite being UB for some cases that we use (through C++14), none of the > compilers we use actually treat it as such, oth

Re: RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Kim Barrett
On Wed, 3 Sep 2025 07:28:49 GMT, Stefan Karlsson wrote: >> Please review this change to offset_of to just use offsetof as it's >> implementation. The rationale for this is >> >> (1) Despite being UB for some cases that we use (through C++14), none of the >> compilers we use actually treat it as

Re: RFR: 8366836: Don't execute post-IncludeCustomExtension if file was not included

2025-09-03 Thread Erik Joelsson
On Wed, 3 Sep 2025 18:49:51 GMT, Magnus Ihse Bursie wrote: > There is a bug in make/common/MakeIncludeEnd.gmk, which makes it always > include the "post" custom extension. In MakeIncludeStart.gmk, the "pre" > custom extension is properly guarded by the check if the file has not already > been

Re: RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Kim Barrett
On Wed, 3 Sep 2025 07:28:49 GMT, Stefan Karlsson wrote: > Nice. Is it worth pushing this so near the transition to compile with C++17 > support? Including the warning suppression gives something that's usefully backportable, which would make it easier to backport changes that happen to include

Re: RFR: 8314488: Compiling the JDK with C++17 [v4]

2025-09-03 Thread Kim Barrett
On Mon, 25 Aug 2025 23:31:03 GMT, Kim Barrett wrote: >> Please review this change to use C++17 for building C++ parts of the JDK. In >> particular this affects HotSpot. This change also includes an update to the >> HotSpot Style Guide regarding C++17 features and their use in HotSpot code. >> >>

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64

2025-09-03 Thread Erik Joelsson
On Wed, 3 Sep 2025 14:51:31 GMT, Aleksey Shipilev wrote: > Anyhow, I believe if non-standard toolchain is involved failing the build is > far better behavior than silently disabling SVE! A common pattern for optionally supported features is to add an explicit `--enable/--disable` flag that tak

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64

2025-09-03 Thread Aleksey Shipilev
On Wed, 3 Sep 2025 14:35:44 GMT, SendaoYan wrote: > Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to make

RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64

2025-09-03 Thread SendaoYan
Hi all, Build jdk on linux-aarch64 with older assembler version(as 2.30) will report compilation failre, shows as [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). This PR add the expression `svfloat64_t a() {}` to makefile which will trigger the compilation during configure stage. A

Integrated: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-03 Thread Aleksey Shipilev
On Tue, 2 Sep 2025 12:30:25 GMT, Aleksey Shipilev wrote: > Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but > switching to Debian trixie. We have waited for about a month for it to > stabilize, and it seems good to switch now. The benefit of doing this now is > making RI

Re: RFR: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-03 Thread Aleksey Shipilev
On Tue, 2 Sep 2025 12:30:25 GMT, Aleksey Shipilev wrote: > Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but > switching to Debian trixie. We have waited for about a month for it to > stabilize, and it seems good to switch now. The benefit of doing this now is > making RI

Re: RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Johan Sjölen
On Tue, 2 Sep 2025 23:25:43 GMT, Kim Barrett wrote: > Please review this change to offset_of to just use offsetof as it's > implementation. The rationale for this is > > (1) Despite being UB for some cases that we use (through C++14), none of the > compilers we use actually treat it as such, oth

Re: RFR: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-03 Thread Albert Mingkun Yang
On Tue, 2 Sep 2025 12:30:25 GMT, Aleksey Shipilev wrote: > Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but > switching to Debian trixie. We have waited for about a month for it to > stabilize, and it seems good to switch now. The benefit of doing this now is > making RI

Re: RFR: 8366195: Remove unnecessary quotes around -Ta ml64 assembler argument

2025-09-03 Thread duke
On Sat, 30 Aug 2025 15:34:00 GMT, Saint Wesonga wrote: > This PR cleans up the handling of the -Ta argument by removing the quotes > that were unintentionally added around the argument and moving the > declaration of the argument to match -Fo as suggested in > https://github.com/openjdk/jdk/pu

RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Kim Barrett
Please review this change to offset_of to just use offsetof as it's implementation. The rationale for this is (1) Despite being UB for some cases that we use (through C++14), none of the compilers we use actually treat it as such, other than some compilers issuing warnings. (Surprisingly, the UB d

RFR: 8363966: GHA: Switch cross-compiling sysroots to Debian trixie

2025-09-03 Thread Aleksey Shipilev
Same as [JDK-8363965](https://bugs.openjdk.org/browse/JDK-8363965), but switching to Debian trixie. We have waited for about a month for it to stabilize, and it seems good to switch now. The benefit of doing this now is making RISC-V sysroot more stable using the same distro as everything else.

Re: RFR: 8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2025-09-03 Thread Stefan Karlsson
On Tue, 2 Sep 2025 23:25:43 GMT, Kim Barrett wrote: > Please review this change to offset_of to just use offsetof as it's > implementation. The rationale for this is > > (1) Despite being UB for some cases that we use (through C++14), none of the > compilers we use actually treat it as such, oth