Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v4]

2025-09-04 Thread SendaoYan
On Thu, 4 Sep 2025 16:51:18 GMT, Erik Joelsson wrote: > Please convert this to using `UTIL_ARG_ENABLE` instead of `AC_ARG_ENABLE`. > There should be several examples available. Using this macro will make the > code easier to understand and promotes unified behavior for all corner cases. I have

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v6]

2025-09-04 Thread SendaoYan
> Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to makefile which will > trigger the compilation during co

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v5]

2025-09-04 Thread SendaoYan
> Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to makefile which will > trigger the compilation during co

Re: RFR: 8361950: Update to use jtreg 8 [v4]

2025-09-04 Thread Christian Stein
> Please review the change to update to using jtreg 8. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersion has been updated in the various `TEST.ROOT` > files. Chris

RFR: 8366836: Don't execute post-IncludeCustomExtension if file was not included

2025-09-04 Thread Magnus Ihse Bursie
There is a bug in make/common/MakeIncludeEnd.gmk, which makes it always include the "post" custom extension. In MakeIncludeStart.gmk, the "pre" custom extension is properly guarded by the check if the file has not already been included. This is not the case for the "post" condition, so a custom

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v4]

2025-09-04 Thread SendaoYan
> Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to makefile which will > trigger the compilation during co

Re: RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell

2025-09-04 Thread Erik Joelsson
On Thu, 4 Sep 2025 14:03:41 GMT, Magnus Ihse Bursie wrote: > When calling ExecuteWithLog with a redirection (using > or, possibly, <), the > entire command needs to be executed in a subshell, that is, inside a pair of > parentheses. This is the callers obligation to ensure, but we have proven

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v4]

2025-09-04 Thread Erik Joelsson
On Thu, 4 Sep 2025 13:45:57 GMT, SendaoYan wrote: >> Hi all, >> >> Build jdk on linux-aarch64 with older assembler version(as 2.30) will report >> compilation failre, shows as >> [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). >> >> This PR add the expression `svfloat64_t a() {}`

RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell

2025-09-04 Thread Magnus Ihse Bursie
When calling ExecuteWithLog with a redirection (using > or, possibly, <), the entire command needs to be executed in a subshell, that is, inside a pair of parentheses. This is the callers obligation to ensure, but we have proven multiple times that this is hard to keep in mind, and we got severa

Re: RFR: 8233115: Protect ExecuteWithLog from running with redirection without a subshell

2025-09-04 Thread Magnus Ihse Bursie
On Thu, 4 Sep 2025 14:03:41 GMT, Magnus Ihse Bursie wrote: > When calling ExecuteWithLog with a redirection (using > or, possibly, <), the > entire command needs to be executed in a subshell, that is, inside a pair of > parentheses. This is the callers obligation to ensure, but we have proven

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v4]

2025-09-04 Thread SendaoYan
On Thu, 4 Sep 2025 13:45:57 GMT, SendaoYan wrote: >> Hi all, >> >> Build jdk on linux-aarch64 with older assembler version(as 2.30) will report >> compilation failre, shows as >> [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). >> >> This PR add the expression `svfloat64_t a() {}`

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v3]

2025-09-04 Thread SendaoYan
> Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to makefile which will > trigger the compilation during co

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v2]

2025-09-04 Thread SendaoYan
> Hi all, > > Build jdk on linux-aarch64 with older assembler version(as 2.30) will report > compilation failre, shows as > [JDK-8366777](https://bugs.openjdk.org/browse/JDK-8366777). > > This PR add the expression `svfloat64_t a() {}` to makefile which will > trigger the compilation during co

Integrated: 8366836: Don't execute post-IncludeCustomExtension if file was not included

2025-09-04 Thread Magnus Ihse Bursie
On Wed, 3 Sep 2025 18:49:51 GMT, Magnus Ihse Bursie wrote: > There is a bug in make/common/MakeIncludeEnd.gmk, which makes it always > include the "post" custom extension. In MakeIncludeStart.gmk, the "pre" > custom extension is properly guarded by the check if the file has not already > been