RFR: 8367801: jtreg failure_handler - don't use the -L option for ps command

2025-09-16 Thread Jaikiran Pai
Can I please get a review of this trivial change to a jtreg failure handler command? As noted in https://bugs.openjdk.org/browse/JDK-8367801, the change in this PR removes the use of "-L" option from the "ps" command to reduce the noise in the output of "ps". I have verified that the command co

Re: RFR: 8361950: Update to use jtreg 8 [v5]

2025-09-16 Thread Christian Stein
On Wed, 17 Sep 2025 06:39:17 GMT, Alan Bateman wrote: >> Christian Stein has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Re: RFR: 8361950: Update to use jtreg 8 [v5]

2025-09-16 Thread Alan Bateman
On Wed, 17 Sep 2025 05:41:55 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 8. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the requiredVers

Re: RFR: 8356379: Need a proper way to test existence of binary from configure

2025-09-16 Thread Julian Waters
On Wed, 7 May 2025 10:57:27 GMT, Magnus Ihse Bursie wrote: > When we setup a command to run, e.g. $FOO we typically set this to just a > path to a binary, e.g. /usr/bin/foo. However, this is not necessarily true. > On Windows, this can be prefixed by the $FIXPATH prefix, and on all platforms >

Re: RFR: 8361950: Update to use jtreg 8 [v4]

2025-09-16 Thread David Holmes
On Thu, 4 Sep 2025 22:01:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 8. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the requiredVersi

Re: RFR: 8344159: Add lint warnings for unnecessary warning suppression

2025-09-16 Thread Joe Darcy
On Tue, 16 Sep 2025 20:03:45 GMT, Archie Cobbs wrote: >> Hi @archiecobbs , are there bugs filed to clean the causes of the warnings? > >> Hi @archiecobbs , are there bugs filed to clean the causes of the warnings? > > Hi @jddarcy, > > At the beginning of this project as a preliminary step I fil

Re: RFR: 8344159: Add lint warnings for unnecessary warning suppression

2025-09-16 Thread Joe Darcy
On Sat, 10 May 2025 20:20:32 GMT, Archie Cobbs wrote: > This PR adds a new compiler warning for `@SuppressWarnings` annotations that > don't actually suppress any warnings. > > Summary of code changes: > > * Add new warning and associated lint category `"suppression"` > * Update `LintMapper` t

Re: RFR: 8252582: HotSpot Style Guide should permit variable templates

2025-09-16 Thread Andrew Dinn
On Mon, 15 Sep 2025 23:47:26 GMT, Kim Barrett wrote: > Anyone else have an opinion? Sorry I am too late to review the PR but I did read the proposal and wish to record approval. - PR Comment: https://git.openjdk.org/jdk/pull/27240#issuecomment-3298236460

Re: RFR: 8366777: Build fails unknown pseudo-op with old AS on linux-aarch64 [v18]

2025-09-16 Thread SendaoYan
On Fri, 12 Sep 2025 13:47:02 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Call AC_MSG_RESULT([$AVAILABLE]) inside AC_COMPILE_IFELSE >> - Use CC directly >> - Move comment from called to mac