Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Chris Plummer
On Wed, 6 Sep 2023 16:06:29 GMT, Erik Joelsson wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Chris Plummer
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v6]

2023-07-19 Thread Chris Plummer
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the

Re: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]

2023-07-17 Thread Chris Plummer
On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate >> `-Xnoagent` option of the `java` command? This addresses >> https://bugs.openjdk.org/browse/JDK-8312072. >> >> As noted in the JBS issue, this option currently is a

Re: RFR: 8312072: Deprecate for removal the -Xnoagent option [v3]

2023-07-16 Thread Chris Plummer
On Sun, 16 Jul 2023 06:34:46 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate >> `-Xnoagent` option of the `java` command? This addresses >> https://bugs.openjdk.org/browse/JDK-8312072. >> >> As noted in the JBS issue, this option currently is a

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Chris Plummer
On Wed, 3 May 2023 19:42:01 GMT, Stefan Karlsson wrote: >> test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java line 30: >> >>> 28: * >>> 29: * @comment Don't allow -Xcomp or -Xint as they impact memory useage >>> and number of iterations >>> 30: * @requires (vm.compMode == "Xmixed") & !(vm.gc.Z

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-03 Thread Chris Plummer
On Wed, 3 May 2023 10:55:49 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-02 Thread Chris Plummer
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote: > Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-02-24 Thread Chris Plummer
On Fri, 24 Feb 2023 15:36:16 GMT, Justin King wrote: > Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Chris Plummer
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Chris Plummer
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote: > `White space following the property value is not ignored, and is treated as > part of the property value.` Although I didn't know this was in the spec, I suspected it might be the case. When looking at the jdk.management.agent changes,

Re: RFR: 8295715: Minimize disabled warnings in serviceability libs

2022-10-20 Thread Chris Plummer
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote: > After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now > possible to disable warnings for individual files instead for whole > libraries. I used this opportunity to go through all disabled warnings in the >

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v6]

2022-09-15 Thread Chris Plummer
On Thu, 15 Sep 2022 23:17:39 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v5]

2022-09-15 Thread Chris Plummer
On Thu, 15 Sep 2022 18:30:46 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2]

2022-09-14 Thread Chris Plummer
On Wed, 14 Sep 2022 21:55:03 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement

Re: RFR: 8293550: Optionally add get-task-allow entitlement to macos binaries [v2]

2022-09-14 Thread Chris Plummer
On Wed, 14 Sep 2022 21:55:03 GMT, Erik Joelsson wrote: >> When signing Macos binaries, it's possible to add various entitlements. We >> already do this for things that Java and the JDK needs when actually signing >> the binaries. >> >> There is a special entitlement