Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v6]

2023-08-16 Thread Dean Long
On Wed, 16 Aug 2023 23:56:58 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v4]

2023-08-16 Thread Dean Long
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v4]

2023-08-16 Thread Dean Long
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v4]

2023-08-16 Thread Dean Long
On Wed, 16 Aug 2023 19:16:28 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-14 Thread Dean Long
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done >> with some effort, given that the signifi

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v4]

2023-08-04 Thread Dean Long
On Fri, 4 Aug 2023 17:05:55 GMT, Matias Saavedra Silva wrote: >> The recent change in >> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more >> -Wconversion warnings that are addressed in this patch. The aforementioned >> change has overlooked inconsistencies with the types

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v2]

2023-08-03 Thread Dean Long
On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva wrote: >> The recent change in >> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more >> -Wconversion warnings that are addressed in this patch. The aforementioned >> change has overlooked inconsistencies with the types

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v2]

2023-08-03 Thread Dean Long
On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva wrote: >> The recent change in >> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more >> -Wconversion warnings that are addressed in this patch. The aforementioned >> change has overlooked inconsistencies with the types

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry [v2]

2023-08-03 Thread Dean Long
On Thu, 3 Aug 2023 19:15:30 GMT, Coleen Phillimore wrote: >> As far as I've designed it, only the last two bits of the flags are ever set >> or used. C++ booleans are either 0 or 1 so the higher bits should never be >> set. > > It is only two bits and the only variable here "is_final_shift" is

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry

2023-08-03 Thread Dean Long
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva wrote: > The recent change in > [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more > -Wconversion warnings that are addressed in this patch. The aforementioned > change has overlooked inconsistencies with the types used

Re: RFR: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry

2023-08-03 Thread Dean Long
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva wrote: > The recent change in > [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more > -Wconversion warnings that are addressed in this patch. The aforementioned > change has overlooked inconsistencies with the types used

Re: RFR: 8310948: Fix ignored-qualifiers warning in Hotspot

2023-06-28 Thread Dean Long
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote: > Please review this attempt to fix ignored-qualifiers warning. > > Example warnings: > > src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier > on return type has no effect [-Wignored-qualifiers] >CompiledMet

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator)

2022-11-15 Thread Dean Long
On Fri, 4 Nov 2022 09:53:39 GMT, Andrew Haley wrote: >> src/java.base/share/classes/java/lang/Thread.java line 1610: >> >>> 1608: ensureMaterializedForStackWalk(bindings); >>> 1609: task.run(); >>> 1610: Reference.reachabilityFence(bindings); >> >> This shoul

Re: RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator)

2022-11-15 Thread Dean Long
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote: > JEP 429 implementation. src/hotspot/share/prims/jvm.cpp line 1410: > 1408: loc = 3; > 1409: } else if (method == resolver.thread_run_method) { > 1410: loc = 2; This depends on how javac numbers locals, right? It seems a bi

Re: RFR: 8290373: Enable lossy conversion warnings on Windows

2022-07-19 Thread Dean Long
On Fri, 15 Jul 2022 13:25:57 GMT, Jorn Vernee wrote: > This patch enables lossy conversion warnings (C4244 [1]) for hotspot on > Windows/MSVC. Instead of fixing all warnings that were produced from this, > I've instead locally disabled the warning in the files that produced > warnings. This al