Re: RFR: 8332854: Unable to build openjdk with --with-harfbuzz=system

2024-06-16 Thread Jayathirth D V
On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote: > Verified on Ubuntu 24.04 I checked build code and looks like by default bundled harfbuzz library is used. With --with-harfbuzz=system, we use system provided harfbuzz lib. Change looks good to me. - Marked as reviewed by jdv (Re

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-28 Thread Jayathirth D V
On Tue, 28 Feb 2023 20:45:38 GMT, Phil Race wrote: >> I think you have read more about the differences between -fpic and -fPIC >> than I have, so nothing I can add here. >> >> Making this option only on aarch64 seems like a reasonable idea if that's >> where we see the effect. > >> I dont thin

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-28 Thread Jayathirth D V
On Tue, 28 Feb 2023 23:55:31 GMT, Sergey Bylokhov wrote: > When I mention that option in the JBS, I meant that we should take a look on > how the methods in the library are "packed" since for some reason "-fpic" > make some difference, probably we should use "static" more often or something >

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 22:58:55 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 126: >

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-27 Thread Jayathirth D V
gt; With this change bimg_misc-* J2DBench option performance regression is > resolved and there are no regression in other options of J2DBench or > SwingMark and it is verified in our performance servers. Jayathirth D V has updated the pull request incrementally with one additi

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 23:02:15 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLib

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 15:14:22 GMT, Erik Joelsson wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 132: >

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
gt; With this change bimg_misc-* J2DBench option performance regression is > resolved and there are no regression in other options of J2DBench or > SwingMark and it is verified in our performance servers. Jayathirth D V has updated the pull request incrementally with one additio

RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of gcc optimizations from -O1 level for libawt build. This improved our J2DBench performance numbers in some options considerably. Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes difference in g