the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Mon, 11 Dec 2023 16:36:09 GMT, Hannes Wallnöfer wrote:
> This is a rather big change to update the structural navigation in API
> documentation generated by JavaDoc. It adds a table of contents for the
> current page to module, package, and class documentation, and replaces the
> old
On Wed, 15 Nov 2023 00:58:51 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/doclet/testMarkdown/TestMarkdown.java line 613:
>>
>>> 611: /// Lorem ipsum.
>>> 612: ///
>>> 613:
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revisi
On Thu, 9 Nov 2023 16:39:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Customize support for Markdown headings
>
> test/langtools/jdk/javadoc/doclet/testM
On Wed, 8 Nov 2023 17:37:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTran
On Wed, 8 Nov 2023 17:28:48 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.
On Wed, 8 Nov 2023 17:28:10 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 64:
>>
>>> 62:
>>> 63: @Test
>>> 64: public void testFindStandardTransformer_raw() throws Exception {
>>
>> Checked exceptions are not thrown:
>>
On Wed, 15 Nov 2023 00:09:17 GMT, Jonathan Gibbons wrote:
>> test/langtools/tools/javac/doctree/FirstSentenceTest.java line 423:
>>
>>> 421: DocComment[DOC_COMMENT, pos:0
>>> 422: firstSentence: 1
>>> 423: RawText[MARKDOWN, pos:0, abc.|def.]
>
On Wed, 8 Nov 2023 17:24:46 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.
On Wed, 8 Nov 2023 10:59:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/tools/javac/doctree/FirstSentenceTest.java l
On Wed, 8 Nov 2023 10:31:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/langtools/tools/javac/doctree/MDPrinter.java line 67:
&
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Fix whit
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Impro
the `commonmark-java`
> library
> * updates to `DocCommentParser` to treat `///` comments as Markdown
> * updates to the standard doclet to render Markdown comments in HTML
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
Please review a patch to add support for Markdown syntax in documentation
comments, as described in the associated JEP.
Notable features:
* support for `///` documentation comments in `JavaTokenizer`
* new module `jdk.internal.md` -- a private copy of the `commonmark-java`
library
* updates to
On Wed, 25 Oct 2023 23:06:59 GMT, Jonathan Gibbons wrote:
> Please review an update to the way that `javadoc` handles the default legal
> notices when generating docs.
>
> Previously, the default notices were taken from the module's `legal`
> directory (`$JAVA_HOME/le
they provided their own minimal file
> manager for use with `javadoc`, which relied on default methods in the file
> manager API. These default methods are not sufficiently for handling paths in
> non-default file systems, such as the `jrt:` file system used to access the
> resour
On Mon, 30 Oct 2023 21:43:11 GMT, Mandy Chung wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclet
On 10/29/23 11:21 AM, Alan Bateman wrote:
On Sat, 28 Oct 2023 21:03:50 GMT, Joe Darcy wrote:
So in terms of a sentence or two of guidance, I think "aim for 10 seconds or less
almost all of the time for a tier 1 test" is reasonable in this context.
Yes, I think making it an aspiration
On Thu, 26 Oct 2023 19:04:16 GMT, Joe Darcy wrote:
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
> regenerate the HTML file once the wording is agreed upon.
doc/testing.md line 138:
> 136: A brief description of the tiered test groups:
> 137:
> 138: - `tier1`: This
they provided their own minimal file
> manager for use with `javadoc`, which relied on default methods in the file
> manager API. These default methods are not sufficiently for handling paths in
> non-default file systems, such as the `jrt:` file system used to access the
> resour
On Thu, 26 Oct 2023 13:29:04 GMT, Magnus Ihse Bursie wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`),
On Wed, 25 Oct 2023 23:38:38 GMT, Erik Joelsson wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`), but
Please review an update to the way that `javadoc` handles the default legal
notices when generating docs.
Previously, the default notices were taken from the module's `legal` directory
(`$JAVA_HOME/legal/jdk.javadoc`), but in some contexts, these files were either
symbolic links, or
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work,
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using
On Tue, 22 Aug 2023 12:19:42 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
Marked as reviewed by jjg (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15387#pullrequestreview-1593864766
On Wed, 26 Jul 2023 09:06:19 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.3.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the
On Fri, 16 Jun 2023 11:14:10 GMT, Jaikiran Pai wrote:
>> Please review this change to use the boot JDK for building jtreg when
>> running on GitHub Actions.
>>
>> This is a best-effort follow-up change to
>> - #14448
>> which didn't have the desired results - the `Bad address` error does still
On Fri, 16 Jun 2023 06:05:16 GMT, Christian Stein wrote:
> Please review this change to use the boot JDK for building jtreg when running
> on GitHub Actions.
>
> This is a best-effort follow-up change to
> - #14448
> which didn't have the desired results - the `Bad address` error does still
>
On Fri, 16 Jun 2023 06:05:16 GMT, Christian Stein wrote:
> Please review this change to use the boot JDK for building jtreg when running
> on GitHub Actions.
>
> This is a best-effort follow-up change to
> - #14448
> which didn't have the desired results - the `Bad address` error does still
>
On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
>> it's useless because the graph nodes are not bordered. This patch converts
>> the non-sealed classes to be rendered in italics instead.
>>
>> An example of
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
test/langtools/tools/javac/versions/Versions.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 4981566 5028634 5094412 6304984 7025786 7025789 8001112 8028545
> 8000961 8030610 8028546 8188870 8173382
On Tue, 9 May 2023 04:11:03 GMT, Chen Liang wrote:
> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
> it's useless because the graph nodes are not bordered. This patch converts
> the non-sealed classes to be rendered in italics instead.
>
> An example of
On Tue, 9 May 2023 06:35:03 GMT, Per Minborg wrote:
>> Please review this simple patch that fixes the package determination for
>> nested classes in the `@sealedGraph` taglet.
>>
>> Current JDK 21:
>>
On Tue, 9 May 2023 03:11:10 GMT, Chen Liang wrote:
> Please review this simple patch that fixes the package determination for
> nested classes in the `@sealedGraph` taglet.
>
> Current JDK 21:
>
On Tue, 18 Apr 2023 12:08:50 GMT, Andrey Turbanov wrote:
> Interesting, why this JBS ticked is considered as a bug?
There's no obvious best choice here (bug, enhancement, task) and as is, it was
the same as for similar previous items.
-
PR Comment:
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now con
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request incrementally with 42 additional
commits since the last revision:
- Merge remote
Please review a cleanup in DocCommentParser to merge blockContent and
inlineContent into a single method to parse "rich content" in a doc comment.
-
Depends on: https://git.openjdk.org/jdk/pull/13362
Commit messages:
- JDK-8305713: DocCommentParser: merge blockContent and
On Tue, 21 Mar 2023 21:08:01 GMT, Jonathan Gibbons wrote:
> Please review a change to introduce a hidden option to temporarily disable
> the "External Specifications" page while we add `@spec` tags, and until we
> have a critical mass of such tags.
This pull request has
> Please review a change to introduce a hidden option to temporarily disable
> the "External Specifications" page while we add `@spec` tags, and until we
> have a critical mass of such tags.
Jonathan Gibbons has updated the pull request incrementally with one additional
co
Please review a change to introduce a hidden option to temporarily disable the
"External Specifications" page while we add `@spec` tags, and until we have a
critical mass of such tags.
-
Commit messages:
- JDK-8304689: Add hidden option to disable external spec page
Changes:
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
On Thu, 9 Mar 2023 19:16:21 GMT, Adam Sotona wrote:
> Newly added Classfile API is based on pattern matching preview feature.
> Unfortunately standard tier1 - 3 tests execution does not involve javadoc
> generation and so it didn't discover missing preview option.
>
> Please review this patch
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote:
>> Yes, iff means if-and-only-if and is used for extra precision in formal
>> logic, mathematics. As @pavelrappo points out it's a relatively common
>> occurrence in the OpenJDK sources, though perhaps not in the public
>> javadocs.
Please review a trivial accessibility fix for the "draft" header in a couple of
index file.
-
Commit messages:
- JDK-8299147: Minor accessibility errors in the specs and man index pages
Changes: https://git.openjdk.org/jdk20/pull/66/files
Webrev:
On Thu, 8 Dec 2022 16:21:30 GMT, Pavel Rappo wrote:
>> This PR proposes adding hyperlinks to the sealed graphic layout making
>> navigation much simpler via the image.
>
> Given that this feature is welcome, I would suggest changing the priority of
> the respective JBS issue to P3, withdrawing
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote:
> This PR proposes adding hyperlinks to the sealed graphic layout making
> navigation much simpler via the image.
make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 209:
> 207: .filter(c -> '.' == c)
> 208:
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the
On Wed, 16 Nov 2022 22:02:43 GMT, Mikael Vidstedt wrote:
> Update to Pandoc 2.19.2 for all Oracle platforms/builds. This updates the
> createPandocBundle.sh script to reflect the bundle layout of the latest
> upstream pandoc bundles, and adds support for an optional platform argument
> to the
On Wed, 16 Nov 2022 13:22:43 GMT, Magnus Ihse Bursie wrote:
> The sjavac ("smart javac") was an ambitious project. It should parallelize
> java compilation, create a background daemon process that kept the JVM "hot"
> with the JITted javac code, define a public api so only noticeable changes
On Wed, 16 Nov 2022 13:22:43 GMT, Magnus Ihse Bursie wrote:
> The sjavac ("smart javac") was an ambitious project. It should parallelize
> java compilation, create a background daemon process that kept the JVM "hot"
> with the JITted javac code, define a public api so only noticeable changes
On Fri, 4 Nov 2022 21:50:10 GMT, Jonathan Gibbons wrote:
> Please review some minor updates to the `diags/examples` mechanism, repairing
> some bitrot after one of the not-so-recent repo reorgs.
>
> For bonus, I've added a target for the German version of the output.
This pull req
On Mon, 7 Nov 2022 12:23:04 GMT, Magnus Ihse Bursie wrote:
> Looks good. Thanks for fixing, and sorry for breaking. :-( At some point, we
> should go through the files in `make/langtools` and check if they all are
> still needed, and so that we document how to test them, in case of future
>
Please review some minor updates to the `diags/examples` mechanism, repairing
some bitrot after one of the not-so-recent repo reorgs.
For bonus, I've added a target for the German version of the output.
-
Commit messages:
- JDK-8296137: diags-examples.xml is broken
Changes:
On Wed, 2 Nov 2022 19:07:36 GMT, Jonathan Gibbons wrote:
> Please review a simple makefile-only update to inject the standard stylesheet
> and navigation header into the two JDK specifications that are generated as
> HTML files in the `gensrc` directory, to bring these doc
Please review a simple makefile-only update to inject the standard stylesheet
and navigation header into the two JDK specifications that are generated as
HTML files in the `gensrc` directory, to bring these docs in line with the rest
of the specs documents.
Generated docs at:
*
On Thu, 27 Oct 2022 20:50:04 GMT, Jonathan Gibbons wrote:
> Please review some updates to the parts of the build system related to
> building the documentation.
This pull request has now been integrated.
Changeset: d17bf51f
Author:Jonathan Gibbons
URL:
https://git.openjdk.o
> Please review some updates to the parts of the build system related to
> building the documentation.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. Th
On Fri, 28 Oct 2022 13:46:27 GMT, Erik Joelsson wrote:
>> Please review some updates to the parts of the build system related to
>> building the documentation.
>
> make/Docs.gmk line 598:
>
>> 596: # Unset the following to suppress the link to the tool guides
>> 597: NAV_LINK_GUIDES =
On Mon, 24 Oct 2022 20:44:08 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
Please review some updates to the parts of the build system related to building
the documentation.
-
Commit messages:
- JDK-8295914: Add a header to generated HTML files in specs
Changes: https://git.openjdk.org/jdk/pull/10891/files
Webrev:
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Wed, 19 Oct 2022 20:41:36 GMT, Magnus Ihse Bursie wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css
>> line 855:
>>
>>> 853: margin: -100px 0 0 100px;
>>> 854: z-index: 1;
>>> 855: }
>>
>> These lines could be merged with the
On Wed, 19 Oct 2022 11:17:07 GMT, Magnus Ihse Bursie wrote:
> It would be possible to mark classes with `@sealedGraph` to indicate that the
> sealed hierarchy should be rendered graphically in the JavaDocs. Classes not
> marked would be unaffected, creating an opt-in approach.
>
>
On Tue, 27 Sep 2022 00:40:48 GMT, David Holmes wrote:
> Revert "8294142: make test should report only on executed tests"
>
> This reverts commit 91a23d775fbf482244ace5758f7b3084ea564460.
>
> Triggers an issue with javatest that causes CI test tasks to fail - see
>
On Fri, 26 Aug 2022 13:48:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change to the testing documentation which
>> adds a note about failure handlers in jtreg? This addresses
>> https://bugs.openjdk.org/browse/JDK-8292911.
>>
>> Recently, there have been users who have
201 - 274 of 274 matches
Mail list logo
