Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Justin Lu
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > FWIW, I checked out the revision

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-09 Thread Justin Lu
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 16 commits: >> >> - Convert the merged master changes to UTF-8 >> -

Re: RFR: 8345940: Migrate security-related resources from Java classes to properties files [v4]

2025-03-10 Thread Justin Lu
On Mon, 10 Mar 2025 14:33:14 GMT, Artur Barashev wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties >> line 40: >> >>> 38: >>> If.keystore.is.not.password.protected.then.storepass.and.keypass.must.not.be.specified=Wenn >>> der Keystore nicht

Re: RFR: 8345940: Migrate security-related resources from Java classes to properties files [v9]

2025-03-10 Thread Justin Lu
On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev wrote: >> These resources files are in Java classes. If converted to properties files, >> the localized versions can use UTF-8 encoding directly. >> >> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java >> ./src/java.base/sha

Re: RFR: 8346773: Fix unmatched brackets in source files

2024-12-23 Thread Justin Lu
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote: > This patch fixes unmatched brackets in some source files. make/data/cldr/common/main/kn.xml line 1085: > 1083: ಇಸ್ಲಾಮಿಕ್ > ಕ್ಯಾಲೆಂಡರ್ > 1084: type="islamic-civil">ಇಸ್ಲಾಮಿಕ್-ಸಿವಿಲ್ ಕ್ಯಾಲೆಂಡರ

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names [v2]

2024-09-23 Thread Justin Lu
On Mon, 23 Sep 2024 15:28:48 GMT, Florian Weimer wrote: >> 8340552: Harden TzdbZoneRulesCompiler against missing zone names > > Florian Weimer has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year LGTM. I agree that this is

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

2024-09-10 Thread Justin Lu
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote: >> This is a follow on fix to >> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out >> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone." >> Same fix, i.e, replacing `startsWith()` with `regionM

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

2024-09-10 Thread Justin Lu
On Tue, 10 Sep 2024 22:39:38 GMT, Naoto Sato wrote: >> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1375: >> >>> 1373: Files.walk(Path.of(tzDataDir), 1, >>> FileVisitOption.FOLLOW_LINKS) >>> 1374: .filter(p -> p.toFile().isFile()) >>> 1375:

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files

2024-09-10 Thread Justin Lu
On Tue, 10 Sep 2024 19:45:01 GMT, Naoto Sato wrote: > This is a follow on fix to > [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out > that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone." > Same fix, i.e, replacing `startsWith()` with `regionMatch

Re: RFR: 8339644: Improve parsing of Day/Month in tzdata rules [v3]

2024-09-06 Thread Justin Lu
On Fri, 6 Sep 2024 21:49:30 GMT, Naoto Sato wrote: >> Fixing TZDB build tool to accommodate full month/day names. Recently >> released tzdb2024b included (inadvertently) full month name "April", which >> is allowed by the spec (zic.8), but never used. This will cause build >> failure of the JD

Re: RFR: 8339644: Improve parsing of Day/Month in tzdata rules [v2]

2024-09-06 Thread Justin Lu
On Fri, 6 Sep 2024 18:10:33 GMT, Naoto Sato wrote: >> Fixing TZDB build tool to accommodate full month/day names. Recently >> released tzdb2024b included (inadvertently) full month name "April", which >> is allowed by the spec (zic.8), but never used. This will cause build >> failure of the JD

Re: RFR: 8174269: Remove COMPAT locale data provider from JDK [v2]

2024-02-26 Thread Justin Lu
On Mon, 26 Feb 2024 21:32:22 GMT, Naoto Sato wrote: >> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The >> `COMPAT` locale data was introduced for applications' migratory purposes >> transitioning to `CLDR`. It is becoming a technical debt and now is the time >> to r

Re: RFR: 8174269: Remove COMPAT locale data provider from JDK [v3]

2024-02-26 Thread Justin Lu
On Mon, 26 Feb 2024 23:37:16 GMT, Naoto Sato wrote: >> This PR intends to remove the legacy `COMPAT` locale data from the JDK. The >> `COMPAT` locale data was introduced for applications' migratory purposes >> transitioning to `CLDR`. It is becoming a technical debt and now is the time >> to r

[jdk22] Integrated: 8321480: ISO 4217 Amendment 176 Update

2024-01-09 Thread Justin Lu
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote: > Please review this PR which is the backport of the ISO 4217 Amendment 176 > Update. Commit > [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc) > from the [openjdk/jdk](https://git.ope

[jdk22] RFR: 8321480: ISO 4217 Amendment 176 Update

2024-01-09 Thread Justin Lu
Please review this PR which is the backport of the ISO 4217 Amendment 176 Update. Commit [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. - Commit messages: - Backport 8b24851

Integrated: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-09-14 Thread Justin Lu
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote: > JDK .properties files still use ISO-8859-1 encoding with escape sequences. It > would improve readability to see the native characters instead of escape > sequences (especially for the L10n process). The majority of files chang

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Justin Lu
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote: > Looks good to me, although I did not look at each l10n file, but sampled > some. Thanks for tackling this conversion. Thanks for the review; (In addition to testing), I ran a script to verify only white space escape sequences exist in JDK .

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Justin Lu
or .properties files need > to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1 > unless manually changed). Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Replace InputStreamReader with BufferedReader ---

RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-09-12 Thread Justin Lu
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It would improve readability to see the native characters instead of escape sequences (especially for the L10n process). The majority of files changed are localized resource files. This change converts the Unicode escape

Integrated: 8306597: Improve string formatting in EquivMapsGenerator.java

2023-05-15 Thread Justin Lu
On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote: > Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in a

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v5]

2023-05-15 Thread Justin Lu
, > the Locale equivalencies builds the same. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Align spacing of the maps to original - Changes: - all: https://git.openjdk.org/jdk/pull/13935/files - new: https://git.op

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

2023-05-12 Thread Justin Lu
On Fri, 12 May 2023 16:41:18 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove more ws in text block > > make/jdk/src/classes/build/tools/generatelsrequivmaps/Equiv

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v4]

2023-05-12 Thread Justin Lu
, > the Locale equivalencies builds the same. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Review: capitalize and move footer text. Add comments to main - Changes: - all: https://git.openjdk.org/jdk/pull/13935/fi

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

2023-05-11 Thread Justin Lu
, > the Locale equivalencies builds the same. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Remove more ws in text block - Changes: - all: https://git.openjdk.org/jdk/pull/13935/files - new: https://git.openjdk.org/jd

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v2]

2023-05-11 Thread Justin Lu
On Thu, 11 May 2023 20:34:48 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Adjust new lines to appease jcheck? >> - Review: remove new line literals for new lines

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v2]

2023-05-11 Thread Justin Lu
, > the Locale equivalencies builds the same. Justin Lu has updated the pull request incrementally with three additional commits since the last revision: - Adjust new lines to appease jcheck? - Review: remove new line literals for new lines - Review: fix method / var names -

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Justin Lu
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Justin Lu
ing the conversion from .properties file to > .java ListResourceBundle file. Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Convert the merged master changes to UTF-8 - Merge master and fix conflicts

RFR: 8306597: Improve string formatting in EquivMapsGenerator.java

2023-05-11 Thread Justin Lu
Please review changes to `EquivMapsGenerator.java` (which is used to generate the Locale equivalencies for the JDK). The file previously used large concatenated Strings, which are now replaced with text blocks, in addition to some cleanup. No functionality is changed, `EquivMapsGenerator.java`

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-31 Thread Justin Lu
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-17 Thread Justin Lu
ing the conversion from .properties file to > .java ListResourceBundle file. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Close streams when finished loading into props - Changes: - all: https://git.openjdk.org/jdk/pul

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Justin Lu
ing the conversion from .properties file to > .java ListResourceBundle file. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Adjust CF test to read in with UTF-8 to fix failing test - Changes: - all: https://git.openj

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v3]

2023-03-16 Thread Justin Lu
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v3]

2023-03-16 Thread Justin Lu
ing the conversion from .properties file to > .java ListResourceBundle file. Justin Lu has updated the pull request incrementally with two additional commits since the last revision: - Reconvert CS.properties to UTF-8 - Revert all changes to CurrencySymbols.properties - Ch

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-03-16 Thread Justin Lu
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-03-16 Thread Justin Lu
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Bug6204853 should not be converted >> - Copyright year for CompilePropert

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-03-16 Thread Justin Lu
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Bug6204853 should not be converted >> - Copyright year for CompileProperties >>

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-03-16 Thread Justin Lu
ing the conversion from .properties file to > .java ListResourceBundle file. Justin Lu has updated the pull request incrementally with four additional commits since the last revision: - Bug6204853 should not be converted - Copyright year for CompileProperties - Redo translation for CS.prope

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support readin

RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Justin Lu
This PR converts Unicode sequences to UTF-8 native in .properties file. (Excluding the Unicode space and tab sequence). The conversion was done using native2ascii. In addition, the build logic is adjusted to support reading in the .properties files as UTF-8 during the conversion from .propertie

RFR: 8303472: Display name for region TR

2023-03-01 Thread Justin Lu
This PR changes the English name for the region `TR`, from `Turkey` to `Türkiye`. Although this change is included in the upcoming CLDR v43, it should be applied as a spot change so that it can be back-ported properly (As it is a common English region name). This change targets both the CLDR