On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote:
> Adding commetns to clarify that the failure_handler selftests are intended to
> be run manually. Ideally this would include a more thorough description of
> the exepcted outputs, but this is what I have time to add right now.
> Adding commetns to clarify that the failure_handler selftests are intended to
> be run manually. Ideally this would include a more thorough description of
> the exepcted outputs, but this is what I have time to add right now.
Ludvig Janiuk has updated the pull request incrementally w
On Fri, 24 May 2024 19:26:29 GMT, Erik Joelsson wrote:
>> Adding commetns to clarify that the failure_handler selftests are intended
>> to be run manually. Ideally this would include a more thorough description
>> of the exepcted outputs, but this is what I have time to add right now.
>
>
Adding commetns to clarify that the failure_handler selftests are intended to
be run manually. Ideally this would include a more thorough description of the
exepcted outputs, but this is what I have time to add right now.
-
Commit messages:
- 8332885 Clarify failure_handler
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
This pull request has now been integrated.
Changeset: c6641c7d
Author:Ludvig Janiuk
Committer: Magnus Ihse Bursie
URL:
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
It's interesting that the order of those two lines can change. I have no idea
what causes it.
-
PR Comment: https://git.openjdk.o
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
Thanks for the insight Erik!
-
PR Comment: https://git.openjdk.org/jdk/pull/18028#issuecomment-1968538692
Clarifying text in `make help` output on how to list variables for e.g.
JTREG='...'.
-
Commit messages:
- 8326831 Clarify test harness control variables in make help
Changes: https://git.openjdk.org/jdk/pull/18028/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18028=00
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
I'll note that you still need to run configure to execute `make test-only
JTREG=help`. Should this really be necessary?
Also, while `make tes
On Mon, 2 Oct 2023 12:36:50 GMT, Ludvig Janiuk wrote:
> This pull request introduces changes in the build makefiles necessary to
> enable the user to specify a jdk to use when launching jtreg. It introduces a
> new configure flag, `--with-jtreg-jdk`, which takes a JDK pat
On Tue, 3 Oct 2023 08:52:06 GMT, Ludvig Janiuk wrote:
>> This pull request introduces changes in the build makefiles necessary to
>> enable the user to specify a jdk to use when launching jtreg. It introduces
>> a new configure flag, `--with-jtreg-jdk`, which takes
; Before this pull request, boot-jdk was always used to launch jtreg. This pull
> request decouples the two, but still defaults to boot-jdk if no value is
> specified.
Ludvig Janiuk has updated the pull request incrementally with one additional
commit since the last revision:
; Before this pull request, boot-jdk was always used to launch jtreg. This pull
> request decouples the two, but still defaults to boot-jdk if no value is
> specified.
Ludvig Janiuk has updated the pull request incrementally with one additional
commit since the last re
This pull request introduces changes in the build makefiles necessary to enable
the user to specify a jdk to use when launching jtreg. It introduces a new
configure flag, `--with-jtreg-jdk`, which takes a JDK path similar to the
already existing `--with-boot-jdk`.
Before this pull request,
On Fri, 29 Sep 2023 17:52:32 GMT, Ludvig Janiuk wrote:
> make/conf/jib-profiles.js passes JT_JAVA in the testOnlyProfiles. This can be
> used to control jtreg's launcher script, but we don't launch that way
> anymore, we launch jtreg directly using jtreg.jar. Therefore this is dea
make/conf/jib-profiles.js passes JT_JAVA in the testOnlyProfiles. This can be
used to control jtreg's launcher script, but we don't launch that way anymore,
we launch jtreg directly using jtreg.jar. Therefore this is dead code and
should be removed.
-
Commit messages:
- 8317327
On Wed, 22 Mar 2023 13:46:48 GMT, Ludvig Janiuk wrote:
> Add quoting not to fail on paths with spaces.
This pull request has now been integrated.
Changeset: 75168eac
Author: Ludvig Janiuk
Committer: Erik Joelsson
URL:
https://git.openjdk.org/jdk/com
Add quoting not to fail on paths with spaces.
-
Commit messages:
- 8304134 jib bootstrapper fails to quote filename when checking download
filetype
Changes: https://git.openjdk.org/jdk/pull/13138/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13138=00
Issue:
On Fri, 10 Feb 2023 18:19:01 GMT, Ludvig Janiuk wrote:
> Update open/test/failure_handler/src/share/conf/(linux,mac).properties to
> handle core dumps more correctly.
This pull request has now been integrated.
Changeset: 6120319a
Author:Ludvig Janiuk
Committer: Erik Joelsso
On Tue, 15 Nov 2022 09:55:38 GMT, Ludvig Janiuk wrote:
> When jib tries to download itself behind a proxy, sometimes it can get a
> different file than it expected. This can result in cryptic errors that are
> hard to troubleshoot. Let's handle this a little more gracefully by
On Wed, 16 Nov 2022 19:59:35 GMT, Magnus Ihse Bursie wrote:
>> bin/jib.sh line 137:
>>
>>> 135: FILEOUTPUT=`file ${installed_jib_script}.gz`
>>> 136: # ${X:${#Y}} gives X without the first ${#Y} characters, and ${#Y}
>>> is length of Y.
>>> 137: FILEOUTPUT=${FILEOUTPUT:${#PREFIX}}
> When jib tries to download itself behind a proxy, sometimes it can get a
> different file than it expected. This can result in cryptic errors that are
> hard to troubleshoot. Let's handle this a little more gracefully by detecting
> it in the bootstrapper and printing an error.
L
> When jib tries to download itself behind a proxy, sometimes it can get a
> different file than it expected. This can result in cryptic errors that are
> hard to troubleshoot. Let's handle this a little more gracefully by detecting
> it in the bootstrapper and printing an error.
L
When jib tries to download itself behind a proxy, sometimes it can get a
different file than it expected. This can result in cryptic errors that are
hard to troubleshoot. Let's handle this a little more gracefully by detecting
it in the bootstrapper and printing an error.
-
Commit
On Wed, 19 Oct 2022 13:57:59 GMT, Ludvig Janiuk wrote:
> Old one made little sense for a new reader
This pull request has now been integrated.
Changeset: b6738c18
Author: Ludvig Janiuk
Committer: Magnus Ihse Bursie
URL:
https://git.openjdk.org/jdk/com
On Wed, 19 Oct 2022 13:57:59 GMT, Ludvig Janiuk wrote:
> Old one made little sense for a new reader
Sure thing, done.
-
PR: https://git.openjdk.org/jdk/pull/10763
> Old one made little sense for a new reader
Ludvig Janiuk has updated the pull request incrementally with one additional
commit since the last revision:
reflow
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10763/files
- new: https://git.openjdk.org/jdk/pull/10763/fi
Old one made little sense for a new reader
-
Commit messages:
- ws
- Rephrased introduction to testing
Changes: https://git.openjdk.org/jdk/pull/10763/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=10763=00
Issue: https://bugs.openjdk.org/browse/JDK-8295663
Stats: 38
On Thu, 1 Sep 2022 16:16:59 GMT, Ludvig Janiuk wrote:
> doc/testing is a starting point for people interested in testing the JDK, but
> it doesn't explain jtreg and its nuances and pitfalls very well.
> https://openjdk.org/jtreg/, and expecially
> https://openjdk.org/jtreg/faq.h
On Thu, 1 Sep 2022 09:09:02 GMT, Ludvig Janiuk wrote:
> Added note to doc/testing and doc/building about the appropriate make target
> to regenerate them.
This pull request has now been integrated.
Changeset: 7c2f2994
Author:Ludvig Janiuk
Committer: Erik Joelsson
URL:
doc/testing is a starting point for people interested in testing the JDK, but
it doesn't explain jtreg and its nuances and pitfalls very well.
https://openjdk.org/jtreg/, and expecially https://openjdk.org/jtreg/faq.html,
contain better material. Let's at least add a pointer that will bring
On Thu, 1 Sep 2022 12:56:47 GMT, Erik Joelsson wrote:
>> Marked as reviewed by erikj (Reviewer).
>
>> @erikj79 Can I ignore the build failure on mac? I must imagine it's an infra
>> failure somehow...
>
> Looks like it failed to download jtreg, so should be safe to ignore.
@erikj79 can I ask
On Thu, 1 Sep 2022 12:26:39 GMT, Erik Joelsson wrote:
>> Added note to doc/testing and doc/building about the appropriate make target
>> to regenerate them.
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 Can I ignore the build failure on mac? I must imagine it's an infra
failure
Added note to doc/testing and doc/building about the appropriate make target to
regenerate them.
-
Commit messages:
- How to edit doc/testing, doc/building
Changes: https://git.openjdk.org/jdk/pull/10115/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=10115=00
Issue:
On Thu, 1 Sep 2022 08:45:19 GMT, Ludvig Janiuk wrote:
> Added note to doc/testing and doc/building about the appropriate make target
> to regenerate them.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/10114
> Added note to doc/testing and doc/building about the appropriate make target
> to regenerate them.
Ludvig Janiuk has refreshed the contents of this pull request, and previous
commits have been removed. Incremental views are not available.
-
Changes:
- all:
Added note to doc/testing and doc/building about the appropriate make target to
regenerate them.
-
Commit messages:
- How to edit doc/testing, doc/building
Changes: https://git.openjdk.org/jdk/pull/10114/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=10114=00
Issue:
37 matches
Mail list logo
