Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 17:01:37 GMT, Roger Riggs wrote: >> That is acceptable, totally. > > Not the rabbit-hole I expected to go down today or for an informal comment on > an internal API. > I have no skin in that game. > https://www.redhat.com/en/topics/linux/what-is-linux Joke, they should know

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:51:46 GMT, David M. Lloyd wrote: >> Well, no. It is just a kernel. Without a userland not an OS. That is why >> they call it GNU/Linux. Kernel + userland. > > If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) > to say that Red Hat identifies "Red

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:08:30 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 66: >> >>> 64: >>> 65: /** >>> 66: * The Linux Operating system. >> >> For the sake if completeness, Linux isn't an operating system, so this >> statement i

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v5]

2023-03-23 Thread Michael Osipov
On Thu, 23 Mar 2023 15:51:48 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 81: >> >>> 79: */ >>> 80: AIX, >>> 81: ; >> >> While browsing another PR I noticed that jlink also has an [OperatingSystem >> enum](https://github.com/op

Re: RFR: 8303485: Replacing os.name for operating system customization [v2]

2023-03-12 Thread Michael Osipov
On Fri, 10 Mar 2023 21:21:56 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-12 Thread Michael Osipov
On Fri, 10 Mar 2023 14:22:17 GMT, Justin King wrote: > > > Has this totally killed of BSD support on the JDK side? I thought > > > building non-macOS BSD was still viable, but perhaps not - certainly not > > > after this change. > > > > > > The macOS port in 7u4 was based on a BSD port and th