Re: RFR: 8294549: configure script should detect unsupported path

2023-11-23 Thread Mike Duigou
On Thu, 23 Nov 2023 15:08:42 GMT, Magnus Ihse Bursie wrote: > The OpenJDK build system does not support building when the source code > resides on a path that contains a space. This requirement is documented in > the build instructions but not enforced by the configure script. > > This change

Re: RFR: 8294549: configure script should detect unsupported path [v2]

2022-12-31 Thread Mike Duigou
On Fri, 2 Dec 2022 13:13:17 GMT, Magnus Ihse Bursie wrote: >> I have removed the path checking from the top level configure script but >> changes are still required in the `configure` wrapper to correctly pass a >> potentially bad path for the real configure script. I considered adding the >>

Re: RFR: 8294549: configure script should detect unsupported path [v2]

2022-12-03 Thread Mike Duigou
On Mon, 7 Nov 2022 00:28:13 GMT, Mike Duigou wrote: >> The OpenJDK build system does not support building when the source code >> resides on a path that contains a space. This requirement is documented in >> the build instructions but not enforced by the configure script.

Re: RFR: 8294549: configure script should detect unsupported path [v2]

2022-12-03 Thread Mike Duigou
On Mon, 7 Nov 2022 12:27:03 GMT, Magnus Ihse Bursie wrote: >> Mike Duigou has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8294549: configure script should detect unsupported path >

Re: RFR: 8294549: configure script should detect unsupported path [v2]

2022-11-06 Thread Mike Duigou
On Mon, 7 Nov 2022 00:28:13 GMT, Mike Duigou wrote: >> The OpenJDK build system does not support building when the source code >> resides on a path that contains a space. This requirement is documented in >> the build instructions but not enforced by the configure script.

Re: RFR: 8294549: configure script should detect unsupported path [v2]

2022-11-06 Thread Mike Duigou
nfigure` script that > fail the build if the source code to be built is located in a directory who's > path contains a space character or the build path cannot be determined. > > Includes some idiom modernization and shell scripting best practices changes. Mike Duigou has updated th

Re: RFR: 8294549: configure script should detect unsupported path

2022-10-31 Thread Mike Duigou
On Thu, 29 Sep 2022 00:09:37 GMT, Mike Duigou wrote: > The OpenJDK build system does not support building when the source code > resides on a path that contains a space. This requirement is documented in > the build instructions but not enforced by the configure script. > > T

Re: RFR: 8294549: configure script should detect unsupported path

2022-09-28 Thread Mike Duigou
On Thu, 29 Sep 2022 00:50:42 GMT, Mikael Vidstedt wrote: >> The OpenJDK build system does not support building when the source code >> resides on a path that contains a space. This requirement is documented in >> the build instructions but not enforced by the configure script. >> >> This chang

RFR: 8294549: configure script should detect unsupported path

2022-09-28 Thread Mike Duigou
The OpenJDK build system does not support building when the source code resides on a path that contains a space. This requirement is documented in the build instructions but not enforced by the configure script. This change adds an explicit checks to the wrapper `configure` script that fail the