Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Patrick Chen
Can you shut the f Le mer. 9 août 2023, 10:10, Thomas Stuefe a écrit : > On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote: > > >> I wrote this code ages ago. I'm not sure what's weird or suspicious > about it, though. The comment at the file's beginning explains this code's > motivation. > >

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Patrick Chen
Relax take it ezzzsy Le mer. 9 août 2023, 08:57, David Holmes a écrit : > On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote: > > >> I just checked and the value of the sentinel is ultimately the prvalue > 88. I don't know if we'd want to replace all the weird char usages here > with expl

Re: RFR: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0

2023-08-02 Thread Patrick Chen
Fuvj you Le mer. 2 août 2023, 21:01, Sergey Bylokhov a écrit : > On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov wrote: > > > One warning is disabled for the freetype. > > Tested with "--with-freetype=bundled", "--with-freetype=system" and w/o > option. > > - > > PR Comment: https:

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Patrick Chen
lgtm Le mar. 28 févr. 2023 à 15:18, Dmitry Markov a écrit : > On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote: > > >> Dmitry Markov has updated the pull request incrementally with one > additional commit since the last revision: > >> > >> Fix review findings > > > > doc/testing.md line

Re: RFR: 8303130: Document required Accessibility permissions on macOS [v2]

2023-02-28 Thread Patrick Chen
pre submit tests failed Le mar. 28 févr. 2023 à 12:04, Dmitry Markov a écrit : > On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov > wrote: > > >> Dmitry Markov has updated the pull request incrementally with one > additional commit since the last revision: > >> > >> Fix review findings > > >

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Patrick Chen
lgtm Le lun. 27 févr. 2023 à 17:17, Jayathirth D V a écrit : > > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level > of gcc optimizations from -O1 level for libawt build. This improved our > J2DBench performance numbers in some options considerably. > > > > Recent changes

Re: RFR: 8300169: Build failure with clang-15

2023-01-17 Thread Patrick Chen
no you have to revert the commit Le mar. 17 janv. 2023 à 17:55, Alan Bateman a écrit : > On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth wrote: > > >> Hi all, > >> > >> Please review the fix for the build failure with clang-15. > >> > >> 1. -Wbitwise-instead-of-logical > >> > >>1) src/ho