On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
This pull request has now been integrated.
Changeset: d130d2f4
Author:SendaoYan
Co
On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang wrote:
>> No, it's an extra newline. A file should end with a newline but one is
>> enough.
>
> As confusing as they are, unfortunately GitHub UI does not render extra
> trailing newlines. This is the only one I could find with grepWin.
I find the
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one
On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
delete extra empty trailing blank li
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Thanks for the review.
Thanks all for the review.
-
PR Comment: https://git.
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
> /label build
Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/
On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan wrote:
>> Hi all,
>> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils
>> --with-binutils-src`. The libiberty.a locates in
>> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib3
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote:
> Hi all,
> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils
> --with-binutils-src`. The libiberty.a locates in
> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32`
> on
On Mon, 3 Jun 2024 09:16:36 GMT, SendaoYan wrote:
>> Hi all,
>> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils
>> --with-binutils-src`. The libiberty.a locates in
>> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib3
On Mon, 3 Jun 2024 08:59:50 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> "or $BINUTILS_INSTALL_DIR/lib64" should probably be on the new line in
>> thi
x86_32.log)
> [configure-ubuntu20-x86_64.log](https://github.com/user-attachments/files/15523978/configure-ubuntu20-x86_64.log)
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
"or $BINUTILS_INSTALL_DIR/lib64" should probably be o
On Sun, 2 Jun 2024 02:49:47 GMT, SendaoYan wrote:
> Hi all,
> This PR try to fix linux x86_32 configure fail with `--with-hsdis=binutils
> --with-binutils-src`. The libiberty.a locates in
> `build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32`
> on
Hi all,
This PR try to fix linux x86_32 configure fail wilth `--with-hsdis=binutils
--with-binutils-src`. The libiberty.a locates in
`build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32` on
linux ubuntu20. The change has been verified, the risk is low.
Additional
On Wed, 1 May 2024 14:46:14 GMT, SendaoYan wrote:
>> Hi,
>>
>> In doc/testing.md file, it says:
>>
>> As an example, :tier1 will expand to
>> jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1
>> jtreg:$(TOPDIR)/test/langtool
On Mon, 29 Apr 2024 16:14:45 GMT, SendaoYan wrote:
> Hi,
>
> In doc/testing.md file, it says:
>
> As an example, :tier1 will expand to jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1
> jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1
> jtreg:$(TOPDIR)/tes
On Wed, 1 May 2024 14:46:14 GMT, SendaoYan wrote:
>> Hi,
>>
>> In doc/testing.md file, it says:
>>
>> As an example, :tier1 will expand to
>> jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1
>> jtreg:$(TOPDIR)/test/langtool
On Tue, 30 Apr 2024 06:25:46 GMT, David Holmes wrote:
> Perhaps we should rephrase this so it is not an exhaustive list that has to
> be updated if the test groupings change. Suggestion:
>
> ```
> As an example, :tier1 will expand to include all subcomponent
> test directories that define
Running test 'jtreg:test/jdk:tier1'
> Running test 'jtreg:test/langtools:tier1'
> Running test 'jtreg:test/jaxp:tier1'
> Running test 'jtreg:test/lib-test:tier1'
>
> Only change the document, no risk.
SendaoYan has updated the pull request incrementally with one additional commit
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote:
> Hi,
>
> The curl command lack of "-L" option, cause download file fail, the size of
> download file is empty.
>
> curl download fail without `-L`:
>```log
>> rm -rf jmh-core-1.37.jar ; curl -
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote:
> Hi,
>
> The curl command lack of "-L" option, cause download file fail, the size of
> download file is empty.
>
> curl download fail without `-L`:
>```log
>> rm -rf jmh-core-1.37.jar ; curl -
Hi,
In doc/testing.md file, it says:
As an example, :tier1 will expand to jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1
jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1
jtreg:$(TOPDIR)/test/nashorn:tier1 jtreg:$(TOPDIR)/test/jaxp:tier1.
The actual situation is :tier1 doesn't
On Sat, 27 Apr 2024 01:15:45 GMT, Jaikiran Pai wrote:
>>> Thank you for those details @sendaoYan.
>>>
>>> Adding `-L` (follow redirects) to unconditionally follow redirects doesn't
>>> look right to me. I think, one would want to know, during the build
>
On Fri, 26 Apr 2024 09:48:51 GMT, SendaoYan wrote:
>> Hello @sendaoYan, who is adding the 302 redirect to that jar location and to
>> which location is the URL being redirected to? What does `curl -v -O
>> ` show in the logs (please paste the textual logs instead of an
>
On Fri, 26 Apr 2024 08:53:21 GMT, Jaikiran Pai wrote:
> Hello @sendaoYan, who is adding the 302 redirect to that jar location and to
> which location is the URL being redirected to? What does `curl -v -O
> ` show in the logs (please paste the textual logs instead of an
> im
Hi,
The curl command lack of "-L" option, cause download file fail, the size of
download file is empty.
Only change devkit shell script, the risk is low.
-
Commit messages:
-
On Thu, 25 Apr 2024 09:47:11 GMT, SendaoYan wrote:
> The script make/devkit/createJMHBundle.sh use fixed maven repo server:
> https://repo.maven.apache.org/maven2. It's maybe useful to make the maven
> repo mirror configurable.
>
> Only change devkit shell script, no risk.
>
On Thu, 25 Apr 2024 09:47:11 GMT, SendaoYan wrote:
> The script make/devkit/createJMHBundle.sh use fixed maven repo server:
> https://repo.maven.apache.org/maven2. It's maybe useful to make the maven
> repo mirror configurable.
>
> Only change devkit shell script, no risk.
Th
On Thu, 25 Apr 2024 11:04:31 GMT, Claes Redestad wrote:
>> The script make/devkit/createJMHBundle.sh use fixed maven repo server:
>> https://repo.maven.apache.org/maven2. It's maybe useful to make the maven
>> repo mirror configurable.
>>
>> Only change devkit shell script, no risk.
>
> Looks
On Thu, 25 Apr 2024 11:04:31 GMT, Claes Redestad wrote:
> Looks reasonable.
Thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/18946#issuecomment-2076994082
The script make/devkit/createJMHBundle.sh use fixed maven repo server:
https://repo.maven.apache.org/maven2. It's maybe useful to make the maven repo
mirror configurable.
Only change devkit shell script, no risk.
-
Commit messages:
- change copyright 2023 to 2024
- 8331113:
32 matches
Mail list logo
