On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -
On Wed, 12 Jun 2024 06:46:39 GMT, Thomas Stuefe wrote:
> A lot better, but not fully there yet. Can you make it so that it also picks
> up SAP's copyrights when they specify multiple years? They are weird in that
> the last year does not have a trailing comma, e.g.:
>
> ```
> * Copyright (c)
here copyright headers missing the copyright symbol (c) were
> not getting picked up. Refer to the example above as well.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with two
additional commits since the last revision:
- Support for co
On Wed, 12 Jun 2024 06:43:15 GMT, Thomas Stuefe wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing optional group to work with bsd as well
>
> make/scripts/update_copyr
On Tue, 11 Jun 2024 13:19:48 GMT, Thomas Stuefe wrote:
>> Opinion: while it's good to see improvements to the existent script, since
>> JEP 330, we can now conveniently implement a similar script in Java. That'll
>> also automatically take care of OS specifics.
>
>> Opinion: while it's good to
here copyright headers missing the copyright symbol (c) were
> not getting picked up. Refer to the example above as well.
>
> Thanks,
> Sonia
Sonia Zaldana Calles has updated the pull request incrementally with one
additional commit since the last revision:
Fixing optional grou
Hi all,
This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
I have added the following enhancements:
- Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
respectively.
- Altered default behaviour to limit the processed changesets to those in the
current
Adding @Thomas Stuefe to the thread.
On Thu, Jun 6, 2024 at 11:20 AM Sonia Zaldana Calles
wrote:
> Hi folks,
>
> I'm working on JDK-8333685 [0].
>
> I was wondering if there would be any objections to removing mercurial
> support from this script along with the few other impr
Hi folks,
I'm working on JDK-8333685 [0].
I was wondering if there would be any objections to removing mercurial
support from this script along with the few other improvements suggested in
the issue above.
Looking forward to your thoughts.
Cheers,
Sonia
[0]