Re: How do I reliably prevent CDS archive generation during builds?

2024-05-06 Thread Thomas Stüfe
Thank you, Eric! On Mon, May 6, 2024 at 7:21 PM wrote: > On 5/6/24 09:26, Thomas Stüfe wrote: > > Hi, > > > > is there a way to reliably prevent the jvm from being called with > > -Xshare:dump during build? > > > > Often, when I tinker with metaspace or

Re: How do I reliably prevent CDS archive generation during builds?

2024-05-06 Thread Thomas Stüfe
Hi Julian, Yes, that confused me too. See here: https://github.com/openjdk/jdk/blob/f308e107ce8b993641ee3d0a0d5d52bf5cd3b94e/make/GenerateLinkOptData.gmk#L76 Cheers, Thomas On Tue, May 7, 2024 at 2:58 AM Julian Waters wrote: > Hi Thomas, > > --disable-jvm-feature-link-time-opt is for

How do I reliably prevent CDS archive generation during builds?

2024-05-06 Thread Thomas Stüfe
Hi, is there a way to reliably prevent the jvm from being called with -Xshare:dump during build? Often, when I tinker with metaspace or compressed klass pointers, CDS gets broken. During development, that is fine; it is a temporary state. However, if -Xshare:dump is invoked, it may crash the

Re: JDK-8170635

2024-05-06 Thread Thomas Stüfe
Not sure if you meant to address this mail to a specific person. I assume with proposal you mean this: https://mail.openjdk.org/pipermail/build-dev/2016-September/017746.html ? If yes, my proposal was to move dladdr out of the OpenJDK code base into an independent library that would be maintained

Re: How to disable warnings treated as errors during the JDK build?

2024-03-15 Thread Thomas Stüfe
Hi Simeon, not a direct help, and I don't know the answer either, but I ran into exactly the same problem today and switched to JDK 19 as boot jdk, which proved a valid workaround. Cheers, Thomas On Fri, Mar 15, 2024 at 4:28 PM S A wrote: > Hi all, > > how do I disable warnings treated as

Re: Hotspot symbol visibility

2024-02-16 Thread Thomas Stüfe
On Fri, Feb 16, 2024 at 10:06 AM Andrew Haley wrote: > On 2/16/24 08:49, Thomas Stüfe wrote: > > It is probably safe to hide C++ mangled symbols since those decorations > are compiler-specific anyway, no? So they cannot have worked in a reliable > fashion > They're not entirely

Re: Hotspot symbol visibility

2024-02-16 Thread Thomas Stüfe
I cannot contribute much to the discussion, but I think this is a valuable effort. These broad exports from hotspot have always bemused me. It is probably safe to hide C++ mangled symbols since those decorations are compiler-specific anyway, no? So they cannot have worked in a reliable fashion?

Re: How current does the build jdk have to be for cross builds

2023-03-31 Thread Thomas Stüfe
Thank you Erik! I expected that. I guess I better rebuild it for every bisect I do. Cheers, Thomas On Fri, Mar 31, 2023 at 3:21 PM wrote: > Hello Thomas, > > On 3/31/23 05:43, Thomas Stüfe wrote: > > Hi, > > > > quick question, I'm doing arm crossbuilds,

How current does the build jdk have to be for cross builds

2023-03-31 Thread Thomas Stüfe
Hi, quick question, I'm doing arm crossbuilds, trying to find an errornous patch with bisecting. With crossbuild, I am specifying build-jdk. How current does the build-jdk have to be? If the build jdk does not fit the source I am trying to build, would that be immediately obvious or would I get

Re: RFR: JDK-8302599: Extend ASan support to Microsoft Visual C++

2023-02-16 Thread Thomas Stüfe
I’m curious, why does the options function have to be exported? Who is consuming it? On Wed 15. Feb 2023 at 19:01, Justin King wrote: > Update build-related infrastructure to support building with ASan under > Microsoft Visual C++. > > - > > Commit messages: > - Move comment to

Put gtest suite back into repository control?

2023-01-26 Thread Thomas Stüfe
Hi, I'm curious, what were the reasons for removing the gtest suite from the repository? That was more convenient, and everyone was using the canonical version. Would it be possible to re-add the gtest suite? Cheers, Thomas

Re: Minimal JVM

2022-07-12 Thread Thomas Stüfe
Hi Julian, the minimal build filters out a whole bunch of optional JVM subsystems in the configure stage, see https://github.com/openjdk/jdk/blob/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4/make/autoconf/jvm-features.m4#L422-L425 That typically manifests via flags like -DINCLUDE_CDS=0, see