On Thu, 30 Mar 2023 06:39:57 GMT, Varada M wrote:
> Breaking this into two parts :
>
> 1. Implementing socket options for AIX
> 2. DontFragmentTest failure
>
> - Implementing socket options for AIX :
>
> Unlike the linux, windows and macOS, AIX uses the default impl
On Mon, 17 Apr 2023 05:13:38 GMT, Jaikiran Pai wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added SO_PEERID failed
>
> Hello Varada, you can go ahead and issue the /integrate
On Fri, 14 Apr 2023 12:32:32 GMT, Varada M wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, window
On Fri, 14 Apr 2023 12:13:39 GMT, Daniel Fuchs wrote:
>> Varada M has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into aix_socket_options
>> - Updat
gt;
> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
Varada M has updated the pull request incrementally with one additional commit
since the last revision:
added SO_PEERID failed
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13240/fi
On Fri, 14 Apr 2023 11:58:53 GMT, Jaikiran Pai wrote:
>> On linux it is implemented from
>> [attachListener_linux.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/attachListener_linux.cpp#L361)
>> and on aix it is from
>>
On Fri, 14 Apr 2023 11:27:33 GMT, Daniel Fuchs wrote:
>> It is intended
>
> I'm curious, what is the rationale?
> By comparison the Linux version has:
>
> handleError(env, rv, "get SO_PEERCRED failed");
On linux it is implemented from
On Fri, 14 Apr 2023 09:10:22 GMT, Daniel Fuchs wrote:
>> Varada M has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' into aix_socket_options
>> - Updat
gt;
> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
Varada M has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains six commits:
- Merge branch 'master' into aix_socket_options
- Updated copyright ye
On Wed, 5 Apr 2023 12:33:40 GMT, Daniel JeliĆski wrote:
> Hi, could you check if the value returned by
> [Java_sun_nio_ch_Net_shouldSetBothIPv4AndIPv6Options0](https://github.com/openjdk/jdk/blob/0deb648985b018653ccdaf193dc13b3cf21c088a/src/java.base/unix/native/libnio/ch/Net.c#L159-L167)
> is
On Tue, 4 Apr 2023 17:48:18 GMT, Vyom Tewari wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to copyright year
>
> Looks OK to me, the native code is same as Linux code with on
gt;
> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
Varada M has updated the pull request incrementally with one additional commit
since the last revision:
Updated copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13240/fi
On Thu, 30 Mar 2023 16:05:08 GMT, Varada M wrote:
>> Breaking this into two parts :
>>
>> 1. Implementing socket options for AIX
>> 2. DontFragmentTest failure
>>
>> - Implementing socket options for AIX :
>>
>> Unlike the linux, window
On Fri, 31 Mar 2023 01:19:05 GMT, Jaikiran Pai wrote:
>> `newInstance("jdk.net.AIXSocketOptions")` will try to invoke the default
>> constructor `AIXSocketOptions() {}`. When we make it as private constructor
>> PlatformSocketOptions instance will try to find jdk.net.AIXSocketOptions and
>>
On Thu, 30 Mar 2023 12:41:26 GMT, Erik Joelsson wrote:
>> Please update the copyright year on this file to `2016, 2023, `
>
> AIX should be covered by `LIBS_unix := -ljava` as long as that's the only lib
> it needs.
@erikj79 @jaikiran I do think `LIBS_unix := -ljava` is the library AIX needs.
On Thu, 30 Mar 2023 11:55:09 GMT, Jaikiran Pai wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to copyright year
>
> src/jdk.net/aix/classes/jdk/net/AIXSocketOptions
On Thu, 30 Mar 2023 11:49:24 GMT, Jaikiran Pai wrote:
>> make/modules/jdk.net/Lib.gmk line 30:
>>
>>> 28:
>>>
>>> 29:
>>> 30: ifeq ($(call isTargetOs, linux macosx windows aix), true)
>>
>> Hello Varada, I'm not
gt;
> Reported Issue : [JDK-8305089](https://bugs.openjdk.org/browse/JDK-8305089)
Varada M has updated the pull request incrementally with one additional commit
since the last revision:
Update to copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13240/fi
Breaking this into two parts :
1. Implementing socket options for AIX
2. DontFragmentTest failure
- Implementing socket options for AIX :
Unlike the linux, windows and macOS, AIX uses the default implementation for
socket options such as ipDontFragmentSupported(),
19 matches
Mail list logo