Integrated: 8334166: Enable binary check

2024-06-23 Thread Zhao Song
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other simil

Re: RFR: 8334166: Enable binary check

2024-06-20 Thread Zhao Song
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other simil

Re: RFR: 8334166: Enable binary check

2024-06-18 Thread Zhao Song
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other simil

Re: RFR: 8334166: Enable binary check

2024-06-18 Thread Zhao Song
On Wed, 12 Jun 2024 23:30:11 GMT, Phil Race wrote: > > > How is this check presented to the PR author and Reviewers of a PR? Is it > > > listed as a warning similar to the issue title warning? Do you have a > > > sample PR (Draft is fine) that would show how this looks? > > > > > >

Re: RFR: 8334166: Enable binary check

2024-06-12 Thread Zhao Song
On Wed, 12 Jun 2024 22:49:30 GMT, Kevin Rushforth wrote: > How is this check presented to the PR author and Reviewers of a PR? Is it > listed as a warning similar to the issue title warning? Do you have a sample > PR (Draft is fine) that would show how this looks?

RFR: 8334166: Enable binary check

2024-06-12 Thread Zhao Song
@kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'.

Integrated: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
On Thu, 9 May 2024 20:53:59 GMT, Zhao Song wrote: > As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and > [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is > able to warn on trailing periods or leading lowercase letter in issue title

Re: RFR: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
On Thu, 9 May 2024 20:53:59 GMT, Zhao Song wrote: > As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and > [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is > able to warn on trailing periods or leading lowercase letter in issue title

RFR: 8332008: Enable issuestitle check

2024-05-09 Thread Zhao Song
As requested in [SKARA-2170](https://bugs.openjdk.org/browse/SKARA-2170) and [SKARA-2248](https://bugs.openjdk.org/browse/SKARA-2248), now Skara bot is able to warn on trailing periods or leading lowercase letter in issue titles. I am going to update the jcheck configuration to configure

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote: >> @erikj79 >> Thanks for the review. >> The code has been updated > > Hi @xpbob, > The jcheck is continuously failing because your GitHub name is `null`. Please > set your name in your profile. > And out of

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 13:58:01 GMT, null wrote: >> null has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add comments > > @erikj79 > Thanks for the review. > The code has been updated Hi @xpbob, The jcheck is continuously failing because