On Tue, 27 Sep 2022 10:28:54 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> There are number of places where misleading-indentation is reported by GCC. > Currently, the warning is disabled for the entirety of Hotspot, which is not > good. > > C1 does an unusual style here. Changing it globally would touch a lot of > lines. Instead of doing that, I fit the existing style while also resolving > the warnings. Note this actually solves a bug in `lir_alloc_array`, where > `do_temp` are called without a check. > > Build-tested this with product of: > - GCC 10 > - {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64} > - {server, zero} > - {release, fastdebug} > > Linux x86_64 fastdebug `tier1` is fine. This pull request has now been integrated. Changeset: 545021b1 Author: Aleksey Shipilev <sh...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/545021b18d6f82ac8013009939ef4e05b8ebf7ce Stats: 56 lines in 5 files changed: 7 ins; 20 del; 29 mod 8294438: Fix misleading-indentation warnings in hotspot Reviewed-by: ihse, dholmes, coleenp ------------- PR: https://git.openjdk.org/jdk/pull/10444