On Wed, 10 Jan 2024 01:58:33 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> Please review this change to enable -Wparentheses when building HotSpot. That > warning is enabled by -Wall (which we use). That was overridden by explicitly > disabling it, because there were a number of places in HotSpot code that > triggered such warnings. Those places have all been fixed. In some cases that > made the code perhaps a little easier to read. There were also a few bugs > found and fixed by that effort. (So -Wparentheses has found existing bugs, and > may prevent future bugs.) > > Testing: mach5 tier1 and GHA sanity checks, to provide build coverage for > Oracle-supported platforms and community-supported platforms. This pull request has now been integrated. Changeset: 8d9814a5 Author: Kim Barrett <kbarr...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/8d9814a5212bd1a339d7a2aa7a5fb4cefe2e9024 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8322757: Enable -Wparentheses warnings Reviewed-by: dholmes, jwaters, erikj, ihse ------------- PR: https://git.openjdk.org/jdk/pull/17335
