Re: RFR: 8252584: HotSpot Style Guide should permit alignas [v2]

2022-11-30 Thread Julian Waters
On Wed, 30 Nov 2022 07:26:46 GMT, Julian Waters wrote: >> Add alignas to the permitted features set with some restrictions. (Thanks >> @kimbarrett for the help) > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8252584: HotSpot Style Guide should permit alignas [v2]

2022-11-30 Thread Julian Waters
On Wed, 30 Nov 2022 07:26:46 GMT, Julian Waters wrote: >> Add alignas to the permitted features set with some restrictions. (Thanks >> @kimbarrett for the help) > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8252584: HotSpot Style Guide should permit alignas [v2]

2022-11-30 Thread Kim Barrett
On Wed, 30 Nov 2022 07:26:46 GMT, Julian Waters wrote: >> Add alignas to the permitted features set with some restrictions. (Thanks >> @kimbarrett for the help) > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8252584: HotSpot Style Guide should permit alignas [v2]

2022-11-29 Thread Julian Waters
> Add alignas to the permitted features set with some restrictions. (Thanks > @kimbarrett for the help) Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull re

Re: RFR: 8252584: HotSpot Style Guide should permit alignas

2022-11-29 Thread Kim Barrett
On Tue, 29 Nov 2022 01:03:55 GMT, Julian Waters wrote: > Add alignas to the permitted features set with some restrictions. (Thanks > @kimbarrett for the help) I think this is okay (not surprisingly). Please add me as a contributor. - Marked as reviewed by kbarrett (Reviewer). PR

RFR: 8252584: HotSpot Style Guide should permit alignas

2022-11-28 Thread Julian Waters
Add alignas to the permitted features set with some restrictions. (Thanks @kimbarrett for the help) - Commit messages: - HotSpot Style Guide changes Changes: https://git.openjdk.org/jdk/pull/11404/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11404&range=00 Issue: https

RFR: 8252584: HotSpot Style Guide should permit alignas

2022-11-23 Thread Julian Waters
Add alignas to the permitted features set. Though the corresponding entry mentions this should not be done for classes, there's no actual difference in practice with all our supported compilers, because their nonstandard syntax also has the same limitations and issues with dynamic allocation as