Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-11 Thread Alexander Zvegintsev
On Wed, 10 May 2023 21:59:37 GMT, Phil Race wrote: > > It is not for the "we have all permissions" case, it is for the case when > > we only have a permission to some screens. So it won't hurt. > > But how does the app know when to call it ? Right now it doesn't know. If the user is not

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-10 Thread Phil Race
On Tue, 9 May 2023 22:09:26 GMT, Alexander Zvegintsev wrote: > > I want to work through the scenarios and how much of it is specific to the > > behaviours of the API you are using and so forth. Since you use the > > Preferences API for saving the token, if you keyed it off the Robot class >

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-09 Thread Alexander Zvegintsev
On Tue, 9 May 2023 20:43:13 GMT, Phil Race wrote: > I want to work through the scenarios and how much of it is specific to the > behaviours of the API you are using and so forth. Since you use the > Preferences API for saving the token, if you keyed it off the Robot class > rather than the

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-09 Thread Phil Race
On Fri, 5 May 2023 14:35:46 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Maxim Kartashev
On Fri, 5 May 2023 14:26:49 GMT, Alexander Zvegintsev wrote: > P.S. I removed synchronized modifier from getRGBPixels My main point was that you don't seem to need to have both, and while I picked one you picked the other ;-) So it's OK. >>

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Thu, 4 May 2023 19:52:22 GMT, Erik Joelsson wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >> - BUILD_LIBPIPEWIRE_HEADER_DIRS ->

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System >

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Fri, 5 May 2023 09:33:00 GMT, Maxim Kartashev wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >> - BUILD_LIBPIPEWIRE_HEADER_DIRS ->