Re: RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

2022-10-20 Thread Aleksey Shipilev
On Thu, 20 Oct 2022 07:34:29 GMT, Aleksey Shipilev wrote: > > @shipilev this has broken our linux aarch64 builds! > > Whoa. Looking. That would be: #10781 - PR: https://git.openjdk.org/jdk/pull/10444

Re: RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

2022-10-20 Thread Aleksey Shipilev
On Thu, 20 Oct 2022 07:14:27 GMT, Aleksey Shipilev wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into JDK-8294438-misleading-indentation >> - Merge branch

Re: RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

2022-10-20 Thread David Holmes
On Thu, 20 Oct 2022 07:14:27 GMT, Aleksey Shipilev wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains five commits: >> >> - Merge branch 'master' into JDK-8294438-misleading-indentation >> - Merge branch

Re: RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

2022-10-20 Thread Aleksey Shipilev
On Wed, 19 Oct 2022 19:11:42 GMT, Aleksey Shipilev wrote: >> There are number of places where misleading-indentation is reported by GCC. >> Currently, the warning is disabled for the entirety of Hotspot, which is not >> good. >> >> C1 does an unusual style here. Changing it globally would touc

Re: RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

2022-10-19 Thread Aleksey Shipilev
> There are number of places where misleading-indentation is reported by GCC. > Currently, the warning is disabled for the entirety of Hotspot, which is not > good. > > C1 does an unusual style here. Changing it globally would touch a lot of > lines. Instead of doing that, I fit the existing st