Re: RFR: 8295229: Try to verify gtest version [v2]

2022-10-12 Thread John R Rose
On Thu, 13 Oct 2022 02:56:01 GMT, Dingli Zhang wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains two >> additional co

Re: RFR: 8295229: Try to verify gtest version [v2]

2022-10-12 Thread Dingli Zhang
On Wed, 12 Oct 2022 14:20:08 GMT, Magnus Ihse Bursie wrote: >> Inspired by the comment >> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for >> JDK-8294623, I realized we need to do at least some kind of version >> verification of gtest. >> >> Since gtest do not properly de

Re: RFR: 8295229: Try to verify gtest version [v2]

2022-10-12 Thread Erik Joelsson
On Wed, 12 Oct 2022 14:20:08 GMT, Magnus Ihse Bursie wrote: >> Inspired by the comment >> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for >> JDK-8294623, I realized we need to do at least some kind of version >> verification of gtest. >> >> Since gtest do not properly de

Re: RFR: 8295229: Try to verify gtest version [v2]

2022-10-12 Thread Magnus Ihse Bursie
> Inspired by the comment > https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for > JDK-8294623, I realized we need to do at least some kind of version > verification of gtest. > > Since gtest do not properly declare its version, this can't be done exactly, > but we can look at