On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote:
>> This turned out to be much more complicated than anticipated. I am going to
>> close this PR (and bug), and instead I have split up this work in five
>> different bugs:
>>
>> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047)
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote:
> and instead I have split up this work in five different bugs
would you consider also adding a unit test to check whether the localized
resources also contain leading/trailing whitespace, and possibly special
characters (like {, }, ,
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit
On Tue, 25 Oct 2022 13:43:56 GMT, Weijun Wang wrote:
> I wonder if this means even if we get everything right now the tool might add
> trailing spaces again later.
Good catch, Max. Yes, that should be dealt with in the translation process.
> I suggest we focus on the English files this time
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote:
> I think it would be better to try and remove incidental trailing whitespace
> first, before encoding any remaining whitespace. Hiding the trailing
> whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping
> the
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote:
> Good idea! I wonder if this should be done as a unit test. go through all the
> bundles and check leading/trailing whitespace.
Right. Definitely not a job for `jcheck`, but it should be considered somewhere
in the l10n process.
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote:
> I think what we can do is check the original English properties values that
> the engineers provided, and if there is no trailing spaces there, we can
> safely remove trailing spaces in localized bundles.
Good idea! I wonder if this should
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote:
> For the files which have trailing "whitespace" (now as unicode sequences), I
> will file follow-up bugs on the respective components to verify if this is
> indeed correct, or a bug that should be fixed.
probably not needed - if
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove check for .properties from jcheck
>> - Restore trailing whitespace for property values
>
> 368 files
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the coverage of the
> whitespace checks (in the old mercurial
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 18:46:04 GMT, Magnus Ihse Bursie wrote:
>> I would vote against this change. Per java properties spec
>> https://github.com/openjdk/jdk/pull/10792
>>
>>
>> White space following the property value is not ignored, and is treated as
>> part of the property value.
>>
>>
>>
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
> `White space following the property value is not ignored, and is treated as
> part of the property value.`
Although I didn't know this was in the spec, I suspected it might be the case.
When looking at the jdk.management.agent changes,
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
Properties files is essentially source code. It should have the same whitespace
checks as all other source code, so we don't get spurious trailing whitespace
changes.
With the new Skara jcheck, it is possible to increase the coverage of the
whitespace checks (in the old mercurial version, this
35 matches
Mail list logo
