Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote: > Please review this PR that removes the remains of old fdTable-based socket > close synchronization. > > Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did > not verify AIX. > > Also removed one slow test for

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 17:08:07 GMT, Daniel Jeliński wrote: >> src/java.base/unix/native/libnet/net_util_md.c line 703: >> >>> 701: >>> 702: errno = 0; >>> 703: read_rv = poll(&pfd, 1, nanoTimeout / NET_NSEC_PER_MSEC); >> >> I suspect this one will need to handle EINTR like the or

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Daniel Jeliński
On Fri, 21 Oct 2022 16:04:24 GMT, Alan Bateman wrote: >> Please review this PR that removes the remains of old fdTable-based socket >> close synchronization. >> >> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. >> Did not verify AIX. >> >> Also removed one slow test

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote: > Please review this PR that removes the remains of old fdTable-based socket > close synchronization. > > Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did > not verify AIX. > > Also removed one slow test for

RFR: 8295792: Clean up old async close code

2022-10-21 Thread Daniel Jeliński
Please review this PR that removes the remains of old fdTable-based socket close synchronization. Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did not verify AIX. Also removed one slow test for an issue in fdtable implementation; as far as I could tell, it is no lo