Re: RFR: 8296926: Use proper include lines for files in include/ [v2]

2022-11-15 Thread Stefan Karlsson
On Tue, 15 Nov 2022 14:25:15 GMT, Erik Joelsson wrote: > Build change looks good. Thanks, Erik. Actually, that change should have been reverted with the last change. I'll revert that. - PR: https://git.openjdk.org/jdk/pull/11133

Re: RFR: 8296926: Use proper include lines for files in include/ [v2]

2022-11-15 Thread Erik Joelsson
On Tue, 15 Nov 2022 10:42:58 GMT, Stefan Karlsson wrote: >> One of the more prevalent issues is that files in src/hotspot/share/include >> are not properly sorted. There has been some discussion that that was done >> on purpose, but it just adds another exception to the include rules that >> d

Re: RFR: 8296926: Use proper include lines for files in include/ [v2]

2022-11-15 Thread Stefan Karlsson
> One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has been some discussion that that was done on > purpose, but it just adds another exception to the include rules that don't > have any practical purposes, IMHO. It also goes against ou