Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-24 Thread Andrey Turbanov
On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be mo

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-23 Thread Christian Stein
On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be mo

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-22 Thread Erik Joelsson
On Tue, 22 Nov 2022 23:32:51 GMT, Magnus Ihse Bursie wrote: >> make/langtools/tools/javacserver/client/Client.java line 148: >> >>> 146: cmd.addAll(Arrays.asList(conf.javaCommand().split(" "))); >>> 147: // javacserver.server.Server is the server main class >>> 148: cmd.a

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-22 Thread Magnus Ihse Bursie
On Tue, 22 Nov 2022 23:15:20 GMT, Erik Joelsson wrote: > Things like incremental builds, some forced failure conditions etc? I tested simple incremental builds but I should probably make a bit more advanced versions where I modify different files to trigger more real-life like scenarios, inclu

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-22 Thread Magnus Ihse Bursie
> Now that the javacserver no longer has any ambitions outside being a > buildtool customized for the JDK build process, a lot of abstractions and > generalizations can be removed. > > This will allow the actual behavior to be more clearly visible, and will help > debugging the issues we are st