On Fri, 2 Dec 2022 16:59:35 GMT, Julian Waters wrote:
> I did change a few lines outside of UTIL_DEFUN_NAMED though, that new issue
> name might not be entirely accurate
Yes, but that is just removing quirks that are not needed now that
UTIL_DEFUN_NAMED is fixed. The essence of the PR is to fi
On Fri, 2 Dec 2022 14:39:59 GMT, Magnus Ihse Bursie wrote:
> And maybe rename the issue `Partially fix string expansion issues in
> UTIL_DEFUN_NAMED`?
I did change a few lines outside of UTIL_DEFUN_NAMED though, that new issue
name might not be entirely accurate
-
PR: https://git
> The UTIL macros have several problematic flaws that may not seem apparent
> initially, the worst of which include parsing commas as actual argument
> separators to the underlying m4 macros, and completely, but very subtly
> wrecking shell constructs. I've done my best here to fix some of these
> The UTIL macros have several problematic flaws that may not seem apparent
> initially, the worst of which include parsing commas as actual argument
> separators to the underlying m4 macros, and completely, but very subtly
> wrecking shell constructs. I've done my best here to fix some of these
On Fri, 2 Dec 2022 13:05:36 GMT, Julian Waters wrote:
>> The UTIL macros have several problematic flaws that may not seem apparent
>> initially, the worst of which include parsing commas as actual argument
>> separators to the underlying m4 macros, and completely, but very subtly
>> wrecking s
On Fri, 2 Dec 2022 14:06:17 GMT, Julian Waters wrote:
>> make/autoconf/util.m4 line 70:
>>
>>> 68: # Proceed at the risk of your own sanity, and don't say I didn't
>>> warn you when you inevitably suffer the same torment that I went through
>>> should you decide
>>> 69: # that you need
On Fri, 2 Dec 2022 14:01:42 GMT, Julian Waters wrote:
>> make/autoconf/util.m4 line 71:
>>
>>> 69: # that you need to dive into it to fix anything
>>> 70: # ~Julian
>>> 71: m4_foreach([arg], m4_dquote(m4_dquote_elt($3)), [
>>
>> I actually had to check up what `m4_dquote` does. It i
On Fri, 2 Dec 2022 13:20:23 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Fri, 2 Dec 2022 13:30:55 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Fri, 2 Dec 2022 13:33:09 GMT, Julian Waters wrote:
>> make/autoconf/util.m4 line 394:
>>
>>> 392: m4_if(ARG_IF_NOT_GIVEN, , [m4_define([ARG_IF_NOT_GIVEN], [:])])
>>> 393: m4_if(ARG_IF_ENABLED, , [m4_define([ARG_IF_ENABLED], [:])])
>>> 394: m4_if(ARG_IF_DISABLED, , [m4_define([ARG_IF_DIS
On Fri, 2 Dec 2022 13:23:43 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> c
On Fri, 2 Dec 2022 13:05:36 GMT, Julian Waters wrote:
>> The UTIL macros have several problematic flaws that may not seem apparent
>> initially, the worst of which include parsing commas as actual argument
>> separators to the underlying m4 macros, and completely, but very subtly
>> wrecking s
On Fri, 2 Dec 2022 13:05:36 GMT, Julian Waters wrote:
>> The UTIL macros have several problematic flaws that may not seem apparent
>> initially, the worst of which include parsing commas as actual argument
>> separators to the underlying m4 macros, and completely, but very subtly
>> wrecking s
> The UTIL macros have several problematic flaws that may not seem apparent
> initially, the worst of which include parsing commas as actual argument
> separators to the underlying m4 macros, and completely, but very subtly
> wrecking shell constructs. I've done my best here to fix some of these
> The UTIL macros have several problematic flaws that may not seem apparent
> initially, the worst of which include parsing commas as actual argument
> separators to the underlying m4 macros, and completely, but very subtly
> wrecking shell constructs. I've done my best here to fix some of these
The UTIL macros have several problematic flaws that may not seem apparent
initially, the worst of which include parsing commas as actual argument
separators to the underlying m4 macros, and completely, but very subtly
wrecking shell constructs. I've done my best here to fix some of these issues
16 matches
Mail list logo
