Re: RFR: 8297984: Turn on warnings as errors for javadoc [v2]

2022-12-02 Thread Magnus Ihse Bursie
> For some reason, we never turned on `-Werror` for javadoc. It is high time to > do so. > > This PR also fixes a recent issue with the javadoc in JFR that caused a > warning, and enables building of javadoc on GHA. (It takes about 3 minutes, > as a separate build job.) Magnus Ihse Bursie has

Re: RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-02 Thread Magnus Ihse Bursie
On Thu, 1 Dec 2022 22:20:00 GMT, Magnus Ihse Bursie wrote: > For some reason, we never turned on `-Werror` for javadoc. It is high time to > do so. > > This PR also fixes a recent issue with the javadoc in JFR that caused a > warning, and enables building of javadoc on GHA. (It takes about 3 m

Re: RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-02 Thread Magnus Ihse Bursie
On Fri, 2 Dec 2022 13:42:23 GMT, Erik Joelsson wrote: > If you would like to exercise the full-docs build in GHA, you could make that > build depend on the linux-x64 build and set `--with-build-jdk` and > `--with-docs-reference-jdk` to point to it. Good point. I don't think it's worth it, thou

Re: RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-02 Thread Erik Joelsson
On Thu, 1 Dec 2022 22:20:00 GMT, Magnus Ihse Bursie wrote: > For some reason, we never turned on `-Werror` for javadoc. It is high time to > do so. > > This PR also fixes a recent issue with the javadoc in JFR that caused a > warning, and enables building of javadoc on GHA. (It takes about 3 m

Re: RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-01 Thread Sergey Bylokhov
On Thu, 1 Dec 2022 22:20:00 GMT, Magnus Ihse Bursie wrote: > For some reason, we never turned on `-Werror` for javadoc. It is high time to > do so. > > This PR also fixes a recent issue with the javadoc in JFR that caused a > warning, and enables building of javadoc on GHA. (It takes about 3 m

RFR: 8297984: Turn on warnings as errors for javadoc

2022-12-01 Thread Magnus Ihse Bursie
For some reason, we never turned on `-Werror` for javadoc. It is high time to do so. This PR also fixes a recent issue with the javadoc in JFR that caused a warning, and enables building of javadoc on GHA. (It takes about 3 minutes, as a separate build job.) - Commit messages: -