Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-28 Thread Jayathirth D V
On Tue, 28 Feb 2023 20:45:38 GMT, Phil Race wrote: >> I think you have read more about the differences between -fpic and -fPIC >> than I have, so nothing I can add here. >> >> Making this option only on aarch64 seems like a reasonable idea if that's >> where we see the effect. > >> I dont thin

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-28 Thread Jayathirth D V
On Tue, 28 Feb 2023 23:55:31 GMT, Sergey Bylokhov wrote: > When I mention that option in the JBS, I meant that we should take a look on > how the methods in the library are "packed" since for some reason "-fpic" > make some difference, probably we should use "static" more often or something >

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-28 Thread Sergey Bylokhov
On Tue, 28 Feb 2023 06:55:36 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-28 Thread Phil Race
On Tue, 28 Feb 2023 13:57:21 GMT, Erik Joelsson wrote: >> Thanks @prrace for your inputs. >> I dont think -fPIC is implied by -fpic. @erikj79 please clarify. >> >> Difference between -fpic and -fPIC: >> 1) With -fPIC we have unlimited storage capacity for global offset table and >> with -fpic

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-28 Thread Erik Joelsson
On Tue, 28 Feb 2023 06:47:37 GMT, Jayathirth D V wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130: >> >>> 128: BUILD_LIBAWT_debug_mem.c_CFLAGS := -w >>> 129: # This option improves performance of FillRect/FillOval in Java2D by >>> 15% for some gcc >>> 130: LIBAWT_CFLAGS

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 22:58:55 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 126: > >> 124: # about initializing a declared

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v3]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 23:02:15 GMT, Phil Race wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130: > >> 128: BUILD_LIBAWT_debug_mem.c_CFLA

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Phil Race
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote: >> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of >> gcc optimizations from -O1 level for libawt build. This improved our >> J2DBench performance numbers in some options considerably. >> >> Recent changes done

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Patrick Chen
lgtm Le lun. 27 févr. 2023 à 17:17, Jayathirth D V a écrit : > > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level > of gcc optimizations from -O1 level for libawt build. This improved our > J2DBench performance numbers in some options considerably. > > > > Recent changes

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
On Mon, 27 Feb 2023 15:14:22 GMT, Erik Joelsson wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 132: > >> 130: # that any cleanup of cod

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64 [v2]

2023-02-27 Thread Jayathirth D V
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes > dif

Re: RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Erik Joelsson
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under

RFR: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-02-27 Thread Jayathirth D V
Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of gcc optimizations from -O1 level for libawt build. This improved our J2DBench performance numbers in some options considerably. Recent changes done under https://bugs.openjdk.org/browse/JDK-8299337 causes difference in g