Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-26 Thread David Holmes
On 25/03/2023 3:06 am, Roger Riggs wrote: On Fri, 24 Mar 2023 16:53:05 GMT, Michael Osipov wrote: If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) to say that Red Hat identifies "Red Hat Enterprise Linux" as an operating system, but I wouldn't go so far as to say th

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 17:01:37 GMT, Roger Riggs wrote: >> That is acceptable, totally. > > Not the rabbit-hole I expected to go down today or for an informal comment on > an internal API. > I have no skin in that game. > https://www.redhat.com/en/topics/linux/what-is-linux Joke, they should know

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:53:05 GMT, Michael Osipov wrote: >> If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) >> to say that Red Hat identifies "Red Hat Enterprise Linux" as an operating >> system, but I wouldn't go so far as to say that Red Hat calls "Linux" an >> ope

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread David M . Lloyd
On Fri, 24 Mar 2023 16:41:02 GMT, Michael Osipov wrote: >> A bit of a quibble, several internet sources identify Linux as an operating >> system (including Redhat). > > Well, no. It is just a kernel. Without a userland not an OS. That is why they > call it GNU/Linux. Kernel + userland. If you

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:51:46 GMT, David M. Lloyd wrote: >> Well, no. It is just a kernel. Without a userland not an OS. That is why >> they call it GNU/Linux. Kernel + userland. > > If you are referring to "Red Hat Enterprise Linux", it'd be correct (AFAIK) > to say that Red Hat identifies "Red

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 16:08:30 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 66: >> >>> 64: >>> 65: /** >>> 66: * The Linux Operating system. >> >> For the sake if completeness, Linux isn't an operating system, so this >> statement i

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:04:38 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 81: >> >>> 79: */ >>> 80: AIX, >>> 81: ; >> >> So no Unknown value? > > Correct, as explained above. If additional OS values are needed, they can be adde

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Naoto Sato
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:03:26 GMT, Michael Osipov wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename OperatingSystem enum values to uppercase > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Roger Riggs
On Fri, 24 Mar 2023 16:02:59 GMT, Michael Osipov wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename OperatingSystem enum values to uppercase > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Alan Bateman
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-24 Thread Michael Osipov
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS) >

Re: RFR: 8303485: Replacing os.name for operating system customization [v6]

2023-03-23 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`