On Tue, 1 Oct 2024 15:46:01 GMT, Roman Kennke wrote:
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java:
>
> I think I would disable the tests for now. Is there a good way to say 'run
> this when UCOH is off OR UseSSE>3?
I don't think so, due to a [limitation in the IR fra
On Mon, 30 Sep 2024 12:38:03 GMT, Roberto Castañeda Lozano
wrote:
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java:
I think I would disable the tests for now. Is there a good way to say 'run this
when UCOH is off OR UseSSE>3?
-
PR Comment: https://git.openjdk
On Thu, 12 Sep 2024 13:20:14 GMT, Emanuel Peter wrote:
> Indeed, I could re-enable all tests in:
>
> ```
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> test/hotspot/jtreg/compiler/loopopts/su
On Fri, 20 Sep 2024 17:34:09 GMT, Coleen Phillimore wrote:
>> Yes. Some background:
>>
>> - wastage can only occur for larger Klass* alignments (aka class space arena
>> alignment property), so only for +COH (note to self, maybe assert)
>> - wastage is, by definition, not aligned to the require
On Wed, 18 Sep 2024 13:57:29 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/classLoaderMetaspace.cpp line 87:
>>
>>> 85: klass_alignment_words,
>>> 86: "class arena");
>>> 87: }
>>
>> As per my comment in the header file, change the code to this:
>>
>> ```c++
>> if (cl
On Wed, 11 Sep 2024 12:27:14 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 87:
>
>> 85: kl
On Wed, 11 Sep 2024 11:29:38 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 52:
>
>> 50: bool is_e
On Tue, 17 Sep 2024 09:59:49 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/classLoaderMetaspace.hpp line 81:
>>
>>> 79: metaspace::MetaspaceArena* class_space_arena() const { return
>>> _class_space_arena; }
>>> 80:
>>> 81: bool have_class_space_arena() const { return _class_
On Wed, 11 Sep 2024 11:25:56 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 48:
>
>> 46:
>> 47: M
On Wed, 11 Sep 2024 13:50:59 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace.cpp line 656:
>
>> 654: // Adjust size
On Wed, 11 Sep 2024 13:05:10 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 165:
>
>> 163: MetaBl
On Wed, 11 Sep 2024 12:25:37 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.hpp line 81:
>
>> 79: metaspac
On Thu, 12 Sep 2024 13:13:01 GMT, Roman Kennke wrote:
>>> @rkennke Can you please explain the changes in these tests:
>>>
>>> ```
>>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
>>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
>>> test/hot
On Wed, 11 Sep 2024 11:25:41 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 51:
>
>> 49: size_t wo
On Thu, 12 Sep 2024 13:13:01 GMT, Roman Kennke wrote:
> > > > @rkennke Can you please explain the changes in these tests:
> > > > ```
> > > > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> > > > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
>
On Wed, 11 Sep 2024 13:34:28 GMT, Roman Kennke wrote:
>> @rkennke Can you please explain the changes in these tests:
>>
>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
>> test/hotspot/jtreg/co
On Wed, 11 Sep 2024 16:14:39 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>>
>>> 200: b_last = b;
>>> 201: }
>>> 202: if (UseNewCode)printf("\n");
>>
>> I guess this line is a leftover to be removed?
>
> Yep thanks for spotting
So th
On Wed, 11 Sep 2024 14:15:12 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>
>> 200
On Wed, 11 Sep 2024 12:47:30 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 115:
>
>> 113: if (wa
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 13:34:28 GMT, Roman Kennke wrote:
> > @rkennke Can you please explain the changes in these tests:
> > ```
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> > test/hotspot/
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 08:24:16 GMT, Emanuel Peter wrote:
> @rkennke Can you please explain the changes in these tests:
>
> ```
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> test/hotspot/jtreg/
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
26 matches
Mail list logo
