Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-14 Thread Thomas Stuefe
On Wed, 11 Sep 2024 21:15:21 GMT, Coleen Phillimore wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert accidental change of UCOH default > > I was starting to understand the concerns with having prototype_heade

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-13 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 11:46:35 GMT, Roberto Castañeda Lozano wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert accidental change of UCOH default > > src/hotspot/share/cds/filemap.cpp line 2457: > >> 2455:

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-13 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 15:38:18 GMT, Thomas Stuefe wrote: >> src/hotspot/share/opto/lcm.cpp line 272: >> >>> 270: const TypePtr* tptr; >>> 271: if ((UseCompressedOops || UseCompressedClassPointers) && >>> 272: (CompressedOops::shift() == 0 || >>> CompressedKlassPointers

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-12 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 15:42:59 GMT, Thomas Stuefe wrote: >> src/hotspot/share/opto/machnode.cpp line 390: >> >>> 388: t = t->make_ptr(); >>> 389: } >>> 390: if (t->isa_narrowklass() && CompressedKlassPointers::shift() == 0) { >> >> Does this change have any effect? `UseCompressedClassPoin

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-12 Thread Thomas Stuefe
On Wed, 11 Sep 2024 14:47:07 GMT, Roberto Castañeda Lozano wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert accidental change of UCOH default > > src/hotspot/share/opto/machnode.cpp line 390: > >> 388:

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-12 Thread Thomas Stuefe
On Thu, 12 Sep 2024 10:17:47 GMT, Roberto Castañeda Lozano wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert accidental change of UCOH default > > src/hotspot/share/opto/lcm.cpp line 272: > >> 270: c

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-12 Thread Roberto Castañeda Lozano
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-12 Thread Roberto Castañeda Lozano
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-11 Thread Coleen Phillimore
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-11 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (