Re: RFR: 8306703: JFR: Summary views [v3]

2023-05-25 Thread Erik Gahlin
On Thu, 25 May 2023 12:22:30 GMT, Markus Grönlund wrote: > This is great work, Erik! It is going to help folks better focus to > understand what is important and the extension capabilities are numerous. > Thank you very much! Thanks for the review! It was a lot to go through. - P

Re: RFR: 8306703: JFR: Summary views [v4]

2023-05-25 Thread Erik Gahlin
> Could I have a review of an enhancement that adds a view command to jfr. > > Testing: tier1, tier2 + jdk/jdk/jfr > > For the change to work properly when streaming, fix of 8307738 needs to be > applied. > > To simplify the review, changes not relevant to the feature, but that can use > class

Re: RFR: 8306703: JFR: Summary views [v3]

2023-05-25 Thread Markus Grönlund
On Thu, 25 May 2023 10:34:45 GMT, Erik Gahlin wrote: >> Could I have a review of an enhancement that adds a view command to jfr. >> >> Testing: tier1, tier2 + jdk/jdk/jfr >> >> For the change to work properly when streaming, fix of 8307738 needs to be >> applied. >> >> To simplify the review,

Re: RFR: 8306703: JFR: Summary views [v3]

2023-05-25 Thread Erik Gahlin
> Could I have a review of an enhancement that adds a view command to jfr. > > Testing: tier1, tier2 + jdk/jdk/jfr > > For the change to work properly when streaming, fix of 8307738 needs to be > applied. > > To simplify the review, changes not relevant to the feature, but that can use > class

Re: RFR: 8306703: JFR: Summary views [v2]

2023-05-24 Thread Andrey Turbanov
On Wed, 24 May 2023 13:46:59 GMT, Erik Gahlin wrote: >> Could I have a review of an enhancement that adds a view command to jfr. >> >> Testing: tier1, tier2 + jdk/jdk/jfr >> >> For the change to work properly when streaming, fix of 8307738 needs to be >> applied. >> >> To simplify the review,

Re: RFR: 8306703: JFR: Summary views [v2]

2023-05-24 Thread Erik Gahlin
> Could I have a review of an enhancement that adds a view command to jfr. > > Testing: tier1, tier2 + jdk/jdk/jfr > > For the change to work properly when streaming, fix of 8307738 needs to be > applied. > > To simplify the review, changes not relevant to the feature, but that can use > class

RFR: 8306703: JFR: Summary views

2023-05-23 Thread Erik Gahlin
Could I have a review of an enhancement that adds a view command to jfr. Testing: tier1, tier2 + jdk/jdk/jfr For the change to work properly when streaming, fix of JDK-8306703 needs to be applied. To simplify the review, changes not relevant to the feature, but that can use classes in jdk.jfr.