Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Axel Boldt-Christmas
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas wrote: >>> I'm getting build warnings on all linux platforms with gcc-11.3.0: >>> >>> ``` >>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, >>> "minor" is defined >>> by . For historical compatibility, it is >>>

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Martin Doerr
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas wrote: >>> I'm getting build warnings on all linux platforms with gcc-11.3.0: >>> >>> ``` >>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, >>> "minor" is defined >>> by . For historical compatibility, it is >>>

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Axel Boldt-Christmas
On Wed, 3 May 2023 21:58:25 GMT, Stefan Karlsson wrote: > I'm getting build warnings on all linux platforms with gcc-11.3.0: > > ``` > src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, > "minor" is defined > by . For historical compatibility, it is > currently defined by

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-03 Thread Stefan Karlsson
On Wed, 3 May 2023 21:32:54 GMT, Martin Doerr wrote: > I'm getting build warnings on all linux platforms with gcc-11.3.0: > > ``` > src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, > "minor" is defined > by . For historical compatibility, it is > currently defined by

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-03 Thread Martin Doerr
On Wed, 3 May 2023 19:36:55 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-03 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap